fix(sync): log ResourceConnectionError at ERROR with missing-connections detail#565
Merged
Merged
Conversation
…ons detail
The except ResourceConnectionError block in _apply_resource_cb was silent at
ERROR level — the failure was only logged once at INFO inside
connect_resources. Downstream consumers that harvest only ERROR-level CLI
output (e.g. dd-source/managed-sync) lost visibility into which dependency
was missing, so dashboards/monitors that skip due to absent SLOs, monitors,
roles, etc. presented as silent failures.
Add a logger.error call mirroring the generic Exception handler so the
failed_connections_dict payload surfaces as
"[<type> - <id>] - missing connections: {...}" in standard output.
Counter, outcome event, and metric tags are unchanged.
heyronhay
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
tests/unit/test_apply_resource_connection_error.pyverify:logger.erroris called once with"missing connections: ..."prefix andresource_type/_idkwargs.skipped.pytest tests/unit/) passes — 578 tests, 0 failures.🤖 Generated with Claude Code