-
Notifications
You must be signed in to change notification settings - Fork 25
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: DataDog/datadog-sync-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.12.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: DataDog/datadog-sync-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4.13.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 7 commits
- 62 files changed
- 4 contributors
Commits on Jul 14, 2026
-
Configuration menu - View commit details
-
Copy full SHA for 734fcde - Browse repository at this point
Copy the full SHA 734fcdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10edf81 - Browse repository at this point
Copy the full SHA 10edf81View commit details -
fix(sensitive_data_scanner_rules): align name with linked standard pa…
…ttern on write (#627)
Configuration menu - View commit details
-
Copy full SHA for 39076f8 - Browse repository at this point
Copy the full SHA 39076f8View commit details
Commits on Jul 15, 2026
-
Configuration menu - View commit details
-
Copy full SHA for e5c800d - Browse repository at this point
Copy the full SHA e5c800dView commit details -
feat: --drop-unresolvable-principals flag + drop-aware connection sca…
…ffolding (1/4) (#629) * feat: add --drop-unresolvable-principals flag and drop-aware connection scaffolding Adds the opt-in `--drop-unresolvable-principals` flag plus the shared, inert-when-off machinery that later PRs wire into individual resource models. No behavior changes when the flag is absent (the default). - New `--drop-unresolvable-principals` CLI option (in `_diffs_options`, so it applies to sync/diffs/migrate) threaded through the `Configuration` dataclass. - `BaseResource._resolve_or_drop`: three-way resolver distinguishing destination-present, source-present ("not yet synced", hard-fail as today), and permanently-gone (absent from both — droppable only under the flag). - Shared `_filter_stale_binding_principals` / `_filter_stale_flat_roles` / `_raise_connection_error_if_any` helpers (rebuild lists rather than mutating in place, avoiding the enumerate/index-shift bug). - `ResourceConnectionError.empty_binding_risk` flag for the access-elevation case. - New `Counter` buckets (stale drops, empty-binding risks) + reset, surfaced by `_emit_apply_summary`; `config.counter` back-reference so models can record drops. - `_apply_resource_cb` adds a `risk:empty_restriction_policy` metric tag when a binding emptied out. Co-Authored-By: Claude Sonnet 5 <[email protected]> * fix: report suppressed empty-binding connection risks * fix: recheck destination after lazy state load * refactor: name resource connection results * fix(restriction_policies): drop stale principals instead of skipping the whole policy (2/4) (#630) * fix(restriction_policies): drop stale principals instead of skipping the whole policy Overrides `connect_resources` so that, under `--drop-unresolvable-principals`, a principal absent from both destination and source state (permanently gone — e.g. a role deleted before the org's first-ever import) is dropped from its binding and the policy still syncs, instead of the entire restriction policy being skipped on a single dead reference. - Principals present in source but not destination keep today's hard-fail/retry behavior. - If dropping empties a binding whose source list was non-empty, the resource is still skipped and flagged as an access-elevation risk (ERROR + metric), governed by `--skip-failed-resource-connections` like any other connection failure. - The "id" (dashboard/slo/notebook) connections keep the generic path unchanged. - `extract_source_ids` is intentionally left unaffected (documented) so minimize-reads lazy-loading can still resolve which principals to check. Co-Authored-By: Claude Sonnet 5 <[email protected]> * fix(monitors,synthetics_tests): drop stale restricted_roles/principals under new flag (3/4) (#631) * fix(monitors,synthetics_tests): drop stale restricted_roles/principals under new flag Applies the same drop-aware pattern (PR1 helpers) to the two resource types that carry both a flat `restricted_roles` list and a `restriction_policy.bindings.principals` composite: - monitors: `restricted_roles` + `restriction_policy.bindings.principals` - synthetics_tests: `options.restricted_roles` + `restriction_policy.bindings.principals` Each `connect_resources` override keeps all non-access-control connections on the generic path, filters access-control references through the shared helpers, and preserves the empty-binding/empty-list access-elevation hard-fail. `extract_source_ids` left unaffected (documented). Behavior is unchanged when `--drop-unresolvable-principals` is off. Co-Authored-By: Claude Sonnet 5 <[email protected]> * fix(dashboards,synthetics_private_locations): drop stale restricted_roles under new flag (#632) Completes the rollout by applying the flat-list drop-aware filter to the two remaining resource types with a `restricted_roles` list: - dashboards: `restricted_roles` - synthetics_private_locations: `metadata.restricted_roles` Both previously had trivial pass-through `connect_id` overrides; they now get a `connect_resources` override that filters stale roles under `--drop-unresolvable-principals` while keeping widget/other connections on the generic path and preserving the empty-list access-elevation hard-fail. Adds a new unit test module for synthetics_private_locations. Co-authored-by: Claude Sonnet 5 <[email protected]> --------- Co-authored-by: Claude Sonnet 5 <[email protected]> --------- Co-authored-by: Claude Sonnet 5 <[email protected]> --------- Co-authored-by: Claude Sonnet 5 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7916f12 - Browse repository at this point
Copy the full SHA 7916f12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 712f182 - Browse repository at this point
Copy the full SHA 712f182View commit details -
Co-authored-by: dd-octo-sts[bot] <200755185+dd-octo-sts[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 88fc8f2 - Browse repository at this point
Copy the full SHA 88fc8f2View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 4.12.0...4.13.0