[K9VULN-16419] Add additional substring detections for proto compiler#928
Merged
Conversation
jasonforal
changed the title
|
🎯 Code Coverage (details) 🔗 Commit SHA: 90c9819 | Docs | Datadog PR Page | Give us feedback! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the static analyzer’s generated-file heuristics (in the kernel’s generated_content detector) so that auto-generated Dart files from protoc are correctly identified and excluded from analysis.
Changes:
- Extend Dart generated-file detection with two additional header substrings commonly emitted by the Dart protobuf compiler/plugins.
- Add unit tests covering the new Dart header variants.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
juli1
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
Some auto generated Dart files are not being detected.
What is your solution?
Add additional substring detections:
"This is a generated file""Generated code. Do not modify"Alternatives considered
*.pb.dart,*.pbenum.dart,*.pbjson.dart, etc