Revert "Temporarily support legacy schema return from the backend"#911
Merged
Conversation
This reverts commit 09c361e.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the previously-added “temporary legacy schema” handling for remote configuration parsing, based on the backend now always returning a v1 configuration when ?schema_version=v1 is used.
Changes:
- Switch remote configuration parsing from
parse_any_schema_yaml(legacy-or-v1) back to strictfile_v1::parse_yaml. - Remove the legacy-to-v1 conversion path for remote configs (
WithVersion::Legacymapping).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
jdelgo
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
When the backend migrated to support the v1 configuration file, there was a manual override that allowed reverting back to the legacy file in case of unforeseen issues. 09c361e was thus added to gracefully handle that scenario. This override has since been removed from the backend, and so given the
?schema_version=v1query param, the backend will always respond with a v1 configuration. Thus, this commit can be reverted now (as was originally intended)