[K9VULN-13253] Panic on error node fix#878
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomainfrom Apr 22, 2026
Merged
[K9VULN-13253] Panic on error node fix#878gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomainfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intomainfrom
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: b037789 | Docs | Datadog PR Page | Give us feedback! |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a panic in the Python static import analyzer when tree-sitter produces malformed AST nodes (e.g., ERROR nodes without a field name) inside import_statements, ensuring analysis continues and still extracts valid imports.
Changes:
- Add a runtime guard in
parse_import_statementto skip named children that are not in the"name"field (preventingERRORnodes from reachingparse_field_child_node). - Add a unit test covering malformed syntax (
import foo, + bar) to ensure parsing does not panic and still returns valid imports.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bahar-shah
previously approved these changes
Apr 15, 2026
jdelgo
force-pushed
the
jdelgo/panic-on-error-fix
branch
from
ae6715b to
7df1bb1
Compare
jdelgo
force-pushed
the
jdelgo/panic-on-error-fix
branch
from
7df1bb1 to
49e09d8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jasonforal
previously approved these changes
Apr 22, 2026
Collaborator
jasonforal
left a comment
jasonforal
left a comment
There was a problem hiding this comment.
Nice! Small nits, because the language feels a bit Claude-y
jasonforal
approved these changes
Apr 22, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
jdelgo/panic-on-error-fix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
The analyzer panics when processing Python files with invalid nodes
What is your solution?
parse_field_child_nodenow returnsOption<MaybeAliased>instead of panicking on unexpected node types. All 3 callers handleNonegracefullyAlternatives considered
An alternative was to skip files at the tree level by checking
has_error()andhas_missing()on the root node inanalyze.rsbut this was too broad as it would skip an entire file for any parse error, even when most of the file is validWhat the reviewer should know
Added two unit tests that first assert the input has an
ERRORnode and then verifies that no panic occurs and the correct imports are returned