Skip to content

[SDS-2263] Introduce online validation v2 to static-analyzer#817

Merged
fbryden merged 3 commits intomainfrom
fbryden/online_validation_v2
Mar 10, 2026
Merged

[SDS-2263] Introduce online validation v2 to static-analyzer#817
fbryden merged 3 commits intomainfrom
fbryden/online_validation_v2

Conversation

@fbryden
Copy link
Copy Markdown
Contributor

@fbryden fbryden commented Feb 16, 2026

What problem are you trying to solve?

Online validation of secrets, V2, as outlined in Security Research's RFC.

What is your solution?

A new set of structs representing the new format, matching what is implemented in dd-sds:

What the reviewer should know

Trying this in staging now

See the ticket for the full context.

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Feb 16, 2026

🎯 Code Coverage (details)
Patch Coverage: 95.03%
Overall Coverage: 85.05% (+0.21%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9ee960b | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@fbryden fbryden changed the title Introduce online validation v2 to static-analyzer [SDS-2263] Introduce online validation v2 to static-analyzer Feb 23, 2026
@fbryden fbryden marked this pull request as ready for review March 5, 2026 13:50
@fbryden fbryden requested a review from a team as a code owner March 5, 2026 13:50
Introduce SecretRuleMatchValidationHttpV2 and SecretRulePairedValidatorConfig
@fbryden fbryden force-pushed the fbryden/online_validation_v2 branch from 7782eec to c1bb4ac Compare March 6, 2026 11:06
@fbryden fbryden changed the base branch from main to gotzon.illarramendi/add-error-code-in-sarif March 6, 2026 11:06
gillarramendi
gillarramendi previously approved these changes Mar 6, 2026
Copy link
Copy Markdown
Contributor

@gillarramendi gillarramendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from gotzon.illarramendi/add-error-code-in-sarif to main March 10, 2026 08:56
@gillarramendi gillarramendi dismissed their stale review March 10, 2026 08:56

The base branch was changed.

@fbryden fbryden merged commit 6955d8c into main Mar 10, 2026
88 of 90 checks passed
@fbryden fbryden deleted the fbryden/online_validation_v2 branch March 10, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants