Conversation
…gainst JSON, now only log message (#996) * refactor(aws)!: AWSX-1703 Change matching of regex. Previously done against JSON, now only on log Signed-off-by: Vincent Boutour <[email protected]> * fixup! refactor(aws)!: AWSX-1703 Change matching of regex. Previously done against JSON, now only on log Signed-off-by: Vincent Boutour <[email protected]> --------- Signed-off-by: Vincent Boutour <[email protected]>
Signed-off-by: Vincent Boutour <[email protected]>
Signed-off-by: Vincent Boutour <[email protected]>
…ation (#1007) Signed-off-by: Vincent Boutour <[email protected]>
…1006) * feat(aws): AWSX-1566 Adding storage tag HTTP header Signed-off-by: Vincent Boutour <[email protected]> * feat(aws): AWSX-1566 Adding new variable in the cloudformation template Signed-off-by: Vincent Boutour <[email protected]> * feat: AWSX-1566 Restoring fetch in the integration test to see metrics Signed-off-by: Vincent Boutour <[email protected]> * fixup! feat: AWSX-1566 Restoring fetch in the integration test to see metrics Signed-off-by: Vincent Boutour <[email protected]> * docs(aws): AWSX-1566 Refine documentation around the new variable Signed-off-by: Vincent Boutour <[email protected]> --------- Signed-off-by: Vincent Boutour <[email protected]>
…udformation and code Signed-off-by: Vincent Boutour <[email protected]>
* feat: Add a changelog for the v5 Signed-off-by: Vincent Boutour <[email protected]> * fixup! feat: Add a changelog for the v5 Signed-off-by: Vincent Boutour <[email protected]> * Update aws/logs_monitoring/CHANGELOG.md Co-authored-by: Raphaël Allier <[email protected]> * fixup! Update aws/logs_monitoring/CHANGELOG.md Signed-off-by: Vincent Boutour <[email protected]> --------- Signed-off-by: Vincent Boutour <[email protected]> Co-authored-by: Raphaël Allier <[email protected]>
ge0Aja
reviewed
Oct 17, 2025
aws/logs_monitoring/CHANGELOG.md
Outdated
|
|
||
| ### Overview | ||
|
|
||
| Version 5.0.0 of the Datadog Lambda Forwarder introduces several breaking changes that remove deprecated features and improve log filtering behavior. This release introduces a new way to enrich your logs with tags that will reduce AWS Lambda related cost (S3, KMS and Lambda). |
Contributor
There was a problem hiding this comment.
nit: prefer to remove you, yours, and just use abstracts i.e. new way to enrich logs
ge0Aja
reviewed
Oct 17, 2025
aws/logs_monitoring/CHANGELOG.md
Outdated
|
|
||
| **Migration Required:** | ||
|
|
||
| - **Review and update your filtering regex patterns** |
ge0Aja
reviewed
Oct 17, 2025
|
|
||
| - Removed the `DD_USE_TCP` / `DdUseTcp` environment variable and parameter | ||
| - Deleted the TCP client implementation | ||
| - All logs now **must** be sent via HTTP/HTTPS |
Contributor
There was a problem hiding this comment.
TCP (transport) doesn't relate to HTTP/HTTPs (application) maybe we should also clarify that logs are sent to a different intake as well?
Contributor
Author
There was a problem hiding this comment.
It's a different intake than the direct TCP intake yes, but it was an internal configuration depending on the DD_SITE and it was not configurable.
ge0Aja
reviewed
Oct 17, 2025
aws/logs_monitoring/CHANGELOG.md
Outdated
| **Migration Required:** | ||
|
|
||
| - Remove any configuration setting `DD_USE_TCP=true` or `DdUseTcp=true` | ||
| - The forwarder will now exclusively use HTTP transport |
Contributor
There was a problem hiding this comment.
nit: HTTP intake (endpoint) instead of transport
Contributor
Author
There was a problem hiding this comment.
Updated to HTTP Protocol
ge0Aja
reviewed
Oct 17, 2025
ge0Aja
reviewed
Oct 17, 2025
ge0Aja
reviewed
Oct 17, 2025
ge0Aja
reviewed
Oct 17, 2025
aws/logs_monitoring/CHANGELOG.md
Outdated
| aws lambda get-function-configuration --function-name "<YOUR_FORWARDER>" --query 'Environment.Variables.DD_USE_TCP' | ||
| ``` | ||
|
|
||
| 2. **Verify you're not using the deprecated PrivateLink variable:** |
Contributor
There was a problem hiding this comment.
Suggested change
| 2. **Verify you're not using the deprecated PrivateLink variable:** | |
| 2. **Verify that deprecated PrivateLink variable is not used:** |
ge0Aja
reviewed
Oct 17, 2025
ge0Aja
reviewed
Oct 17, 2025
ge0Aja
reviewed
Oct 17, 2025
aws/logs_monitoring/CHANGELOG.md
Outdated
|
|
||
| **Migration Required:** | ||
|
|
||
| - **Review and update your filtering regex patterns** |
Contributor
There was a problem hiding this comment.
Suggested change
| - **Review and update your filtering regex patterns** | |
| - **Review and update filtering regex patterns** |
ge0Aja
approved these changes
Oct 17, 2025
Contributor
ge0Aja
left a comment
ge0Aja
left a comment
There was a problem hiding this comment.
lgtm, some comments on the change-log
Co-authored-by: Georgi <[email protected]>
Co-authored-by: Georgi <[email protected]>
Co-authored-by: Georgi <[email protected]>
Co-authored-by: Georgi <[email protected]>
Co-authored-by: Georgi <[email protected]>
Signed-off-by: Vincent Boutour <[email protected]>
Signed-off-by: Vincent Boutour <[email protected]>
* feat: Add link to the changelog in the read toe reflect the documentation The readme is feeding this page https://docs.datadoghq.com/logs/guide/forwarder/?tab=cloudformation Signed-off-by: Vincent Boutour <[email protected]> * fixup! feat: Add link to the changelog in the read toe reflect the documentation Signed-off-by: Vincent Boutour <[email protected]> --------- Signed-off-by: Vincent Boutour <[email protected]>
* refactor: Improve error handling for exception Signed-off-by: Vincent Boutour <[email protected]> * fixup! refactor: Improve error handling for exception Signed-off-by: Vincent Boutour <[email protected]> * fixup! refactor: Improve error handling for exception Signed-off-by: Vincent Boutour <[email protected]> --------- Signed-off-by: Vincent Boutour <[email protected]>
ge0Aja
reviewed
Oct 22, 2025
| "Encountered an error while trying to parse and submit enhanced metrics for log %s", | ||
| except Exception as e: | ||
| logger.error( | ||
| "Encountered an error while trying to parse and submit enhanced metrics for log %s: %s", |
Contributor
There was a problem hiding this comment.
nit: we could use the same formatted string approach that's used every where else
ge0Aja
reviewed
Oct 22, 2025
Co-authored-by: Georgi <[email protected]>
Signed-off-by: Vincent Boutour <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply