Fix deterministic ordering for multiple package versions with lockfiles#99
Merged
piloulacdog merged 5 commits intomainfrom Jan 23, 2026
Merged
Conversation
Go test coverage reportTotal test coverage: 90.5% (4352/4807) Test coverage has changed in the current files, with 1 lines missing coverage. |
rjcoulter22
reviewed
Jan 22, 2026
rjcoulter22
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Motivation
Identified an issue when running consistency check for our running on a nuget package: https://github.com/DataDog/software-composition-analysis-test/actions/runs/21254063506
When NuGet projects use lockfiles with multiple target frameworks that reference different versions of the same package, the SBOM generator was producing non-deterministic results. This occurred because the package matching logic used only package names as keys, causing unpredictable behavior when multiple versions existed. This non-determinism makes SBOMs unreliable and difficult to compare across builds.
The fix ensures that when the same package+version appears multiple times (e.g., in different conditional ItemGroups), we consistently pick the first occurrence by line number, making the output deterministic and reproducible.
🧪 Testing