Skip to content

[K9VULN-6226] Fix transient report of 'is-dev' property in SBOM generation#79

Merged
piloulacdog merged 2 commits intomainfrom
pierrelouis.lacorte/K9VULN-6226-consistent-is-dev-attributes
Nov 6, 2025
Merged

[K9VULN-6226] Fix transient report of 'is-dev' property in SBOM generation#79
piloulacdog merged 2 commits intomainfrom
pierrelouis.lacorte/K9VULN-6226-consistent-is-dev-attributes

Conversation

@piloulacdog
Copy link
Copy Markdown
Contributor

@piloulacdog piloulacdog commented Nov 5, 2025

🚀 Motivation

Fix transient report of the 'is-dev' property that was causing inconsistency issues in SBOM generation, as identified in recent comparison runs.

📝 Summary

Added a new test fixture file is-dev-inconsistency.v9.yaml for pnpm lockfile format to reproduce and test the transient 'is-dev' property issue. This fixture contains a comprehensive pnpm v9 lockfile with various dependency configurations including dev dependencies, catalogs, and workspace references to ensure consistent is-dev property reporting.

🧪 Testing

  • New tests were added for new logic.
  • Existing tests were updated for new logic, and not only so that they pass!
  • Benchmark results prove that performance is the same or better.

@piloulacdog piloulacdog requested a review from a team as a code owner November 5, 2025 17:51
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 5, 2025

Go test coverage report

Total test coverage: 90.9% (3933/4325)

Test coverage has changed in the current files, with 1 lines missing coverage.
file: uncovered: current coverage: base coverage:
pkg/lockfile/parse-pnpm-v9-lock.go 1 98.8% (79/80) 97.5% (78/80)

@piloulacdog piloulacdog merged commit 469cccf into main Nov 6, 2025
11 checks passed
@piloulacdog piloulacdog deleted the pierrelouis.lacorte/K9VULN-6226-consistent-is-dev-attributes branch November 6, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants