[K9VULN-13445] Rename lockfile directory#156
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoMay 26, 2026
Merged
[K9VULN-13445] Rename lockfile directory#156gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: b63f684 | Docs | Datadog PR Page | Give us feedback! |
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
divya.vithiyatharan/rename-lockfile-dir
branch
May 26, 2026 18:00
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
The
pkg/lockfiledirectory name is misleading since it handles both lockfiles and source/manifest file matchers, so roughly half its contents are not lockfiles at all.What is your solution?
lockfiletoextractor, which better reflects the package's purpose as the core extraction layer.Alternatives considered
Name options:
extractor,depfile,parsers,lockfile(keep it)What the reviewer should know
This is a pure rename, no logic changes.