[K9VULN-11116] Fix panic when unable to open file during lockfile scanning#100
Merged
piloulacdog merged 1 commit intomainfrom Jan 23, 2026
Merged
[K9VULN-11116] Fix panic when unable to open file during lockfile scanning#100piloulacdog merged 1 commit intomainfrom
piloulacdog merged 1 commit intomainfrom
Conversation
Go test coverage reportTotal test coverage: 90.5% (4336/4792) Test coverage has changed in the current files, with 21 lines missing coverage. |
piloulacdog
approved these changes
Jan 23, 2026
piloulacdog
reviewed
Jan 23, 2026
Contributor
piloulacdog
left a comment
piloulacdog
left a comment
There was a problem hiding this comment.
no test... but let's get it out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Motivation
The scanner would panicking with a nil pointer dereference when attempting to close a file that failed to open. This panic was swallowing the actual scan failure reason, making it difficult to diagnose why certain repository scan failures occur.
📝 Summary
Changed the control flow in
scanLockfilefunction to handle file opening errors properly. Instead of attempting to close a nil file pointer whenOpenLocalDepFilefails, the function now returns early with the error. The deferredfile.Close()call is now only executed when the file was successfully opened, preventing the nil pointer dereference panic.