[NO-TICKET] Remove 4.0.0-preview2 headers and bump gem version to 3.5.2#26
Merged
Conversation
We no longer need these! I also adjusted the specs so we keep test coverage for when preview and non-preview headers are mixed.
This folder is small but it's not needed!
anmarchenko
approved these changes
Jan 23, 2026
p-datadog
approved these changes
Jan 23, 2026
Member
Author
|
Thanks y'all for the review, going ahead with merging and releasing! |
ivoanjo
added a commit
to DataDog/dd-trace-rb
that referenced
this pull request
Jan 26, 2026
**What does this PR do?** This PR bumps the minimum version of the datadog-ruby_core_source gem to the latest version (3.5.2), having the usual diff (e.g. #5236 was the previous update). **Motivation:** Doing this bump forces updates to the datadog gem to also pull in the latest version of the datadog-ruby_core_source gem. This ensures users have the best experience and don't e.g. run into issues because somehow they're running the latest version of the gem with an outdated version of the headers. Specifically version 3.5.2 drops support for the Ruby 4.0.0-preview2 headers, so overall should not impact anyone, while at the same time having a smaller on-disk footprint (DataDog/datadog-ruby_core_source#26). **Additional Notes:** N/A **How to test the change?** Green CI is good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR:
Finishes the "Ruby 4.0.0" stable is now out cleanups started in [PROF-13303] Remove 3.5.0-preview1 and 4.0.0-preview3 headers and bump gem version to 3.5.0 #24 and finally drops the last remaining non-stable set of headers, for 4.0.0-preview2.
Bumps the gem version to 3.5.2 in preparation for release
Removes the
spec/folder from the packaged gem artifact (to reduce it slightly)Motivation:
In #24 I mentioned
This is no longer the case, so let's reduce the on-disk footprint of the gem by shedding this last set of headers.
Additional Notes:
N/A
How to test the change?
In #25 we ran into a bug in header version selection caused by mixing preview and non-preview headers, and added a few integration-like specs for it. To keep the specs working, I've tweaked the tests to keep faking that the 4.0.0-preview2 header folder is still around.
I've also packaged this locally and tried installing it on 4.0.0/4.0.1/3.4.7.