[PROF-13303] Add Ruby 4.0.0-preview3 headers and bump gem version to 3.4.3#22
Merged
Merged
Conversation
This tiny change came in handy for testing, so "why not"?
The 4.0.0-preview2 headers are not compatible with -preview3 -- in particular there's a new field in the thread structure that changes the offset of everything that comes after it, and thus makes the profiler crash on preview3 when compiled with preview2 headers. I followed the usual instructions from the `README.md` to extract the headers.
The changelog is easy to forget, and anyway changes in this gem/repo are easy to identify by looking at PRs/commits so this doesn't offer much value IMHO.
AlexJF
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR imports the Ruby 4.0.0-preview3 headers into the gem.
Motivation:
The 4.0.0-preview2 headers are not compatible with preview3 -- in particular there's a new field in the thread structure that causes the offset of everything that comes after it to shift, and thus makes the profiler crash on preview3 when compiled with preview2 headers.
Additional Notes:
This PR is very similar to #15, and I followed the usual instructions from the
README.mdto extract the headers.I've decided to delete the changelog file as it's easy to forget (it was already outdated), and changes in this gem/repo are easy to identify by looking at PRs/commits so this didn't offer much value.
How to test the change?
I've tested this PR by running the ruby profiler test suite on Ruby 4.0.0-preview3. Other than tiny small behavior changes that happened between preview2 and preview3 the ruby profiler test suite is green with the updated headers.
At some point we'll have CI in dd-trace-rb for Ruby 4.0.0-preview3 (or later), but currently this needs to be tested locally.