[PROF-13115] Revert "Temporarily skip broken Ruby 4 test to unblock gem release"#21
Merged
Merged
Conversation
…em release" **What does this PR do?** This reverts commit 551b5ae from #20. See #20 for details. In that PR I mentioned: So to break the loop, let's: 1. omit this test temporarily: ✅ done -> this was #20 2. then we can release this gem: ✅ done -> https://github.com/DataDog/datadog-ruby_core_source/actions/runs/20059401843, [version 3.4.2 is on rubygems.org](https://rubygems.org/gems/datadog-ruby_core_source/versions/3.4.2) 3. then we can undo the dd-trace-rb pinning: ✅ done -> DataDog/dd-trace-rb#5122 4. then we can re-enable the test This PR is step 4 and gets us back to where we were before the workaround. **Motivation:** Remove workaround now that it's not needed anymore! **Additional Notes:** N/A **How to test the change?** Validate that Ruby 4.0 + "corruption" test is running in CI and green.
sarahchen6
approved these changes
Dec 9, 2025
Contributor
|
BTW - thanks for such a clear PR description! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This reverts commit 551b5ae from #20.
See #20 for details. In that PR I mentioned:
To break the loop, let's:
https://github.com/DataDog/datadog-ruby_core_source/actions/runs/20059401843, version 3.4.2 is on rubygems.org
[PROF-13115] Bump minimum datadog-ruby_core_source dependency to 3.4.2 dd-trace-rb#5122
This PR is step 4 and gets us back to where we were before the workaround.
Motivation:
Remove workaround now that it's not needed anymore!
Additional Notes:
N/A
How to test the change?
Validate that Ruby 4.0 + "corruption" test is running in CI and green.