[PROF-11203] Add Ruby 3.4.0 stable headers and bump gem version to 3.4.0#14
Merged
Merged
Conversation
These are no longer needed now that Ruby 3.4.0 stable is out.
These were the output of running `bundle exec rake add_source VERSION=3.4.0` For some weird reason the `archive-tar-minitar` gem was getting stuck calling fsync so I had to `bundle open` the gem and disable the fsync code.
Also manually removed the `*.inc` files.
These are no longer needed now that Ruby 3.4.0 stable is out.
The missing patchlevel is due to an upstream bug (which is the reason why Ruby 3.4.1 was immediately released after 3.4.0), so let's manually account for it.
TonyCTHsu
approved these changes
Jan 27, 2025
ivoanjo
added a commit
that referenced
this pull request
Apr 23, 2025
…3.4.1 **What does this PR do?** This PR imports the Ruby 3.5.0-preview1 headers into the gem. **Motivation:** These headers are needed to get the Datadog Ruby profiler to work correctly on Ruby 3.5.0-preview1. (I tried without these updated headers and it broke since it will try to fall back to the 3.4 headers). **Additional Notes:** This PR is very similar to #14 . **How to test the change?** I've tested this PR by running the ruby profiler test suite on both Ruby 3.4.1 and 3.5.0-preview1 with these changes, and validating it was green. At some point we'll have CI in dd-trace-rb for Ruby 3.5, but currently this testing was done locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR:
Motivation:
Although in practice this doesn't seem to make a difference for dd-trace-rb, the 3.4.0-rc1 headers are not exactly the same as the 3.4.0 stable ones (if you examine the diff) so we should use the correct version.
Furthermore, we reduce the on-disk footprint by not having two sets of 3.4.0 headers.
Additional Notes:
N/A
How to test the change?
I've locally tested the new gem with: