Skip to content

[PROF-11035] Fix breaking "publish gem" due to optional development group#12

Merged
ivoanjo merged 1 commit into
masterfrom
ivoanjo/prof-11035-clean-up-gemfile
Dec 16, 2024
Merged

[PROF-11035] Fix breaking "publish gem" due to optional development group#12
ivoanjo merged 1 commit into
masterfrom
ivoanjo/prof-11035-clean-up-gemfile

Conversation

@ivoanjo

@ivoanjo ivoanjo commented Dec 16, 2024

Copy link
Copy Markdown
Member

What does this PR do?

This PR removes the optional development group with the pry gem. It was added in #8, but it being optional breaks the "publish gem" github flow with:

Run bundle exec rake release
bundler: failed to load command: rake (/opt/hostedtoolcache/Ruby/3.2.4/x64/bin/rake)
/opt/hostedtoolcache/Ruby/3.2.4/x64/lib/ruby/3.2.0/bundler/rubygems_integration.rb:308:in `block in replace_bin_path': can't find executable rake for gem rake. rake is not currently included in the bundle, perhaps you meant to add it to your Gemfile? (Gem::Exception)

I was able to reproduce the same issue locally, it happens because the development group was marked optional.

Since this has been a bit of a back and forth, for now let's just remove pry and we can add it back locally or whatnot if when needed.

Motivation:

This is blocking the 3.3.7 release, see
https://github.com/DataDog/datadog-ruby_core_source/actions/runs/12354204200/job/34475175057#step:4:5

Additional Notes:

N/A

How to test the change?

Without this PR, locally running bundle exec rake fails for me with the error above; with this change, I'm able to run rake successfully.

…roup

**What does this PR do?**

This PR removes the optional development group with the `pry` gem.
It was added in #8, but it being optional breaks the "publish gem"
github flow with:

```
Run bundle exec rake release
bundler: failed to load command: rake (/opt/hostedtoolcache/Ruby/3.2.4/x64/bin/rake)
/opt/hostedtoolcache/Ruby/3.2.4/x64/lib/ruby/3.2.0/bundler/rubygems_integration.rb:308:in `block in replace_bin_path': can't find executable rake for gem rake. rake is not currently included in the bundle, perhaps you meant to add it to your Gemfile? (Gem::Exception)
```

I was able to reproduce the same issue locally, it happens because
the development group was marked optional.

Since this has been a bit of a back and forth, for now let's
just remove `pry` and we can add it back locally or whatnot if
when needed.

**Motivation:**

This is blocking the 3.3.7 release, see
https://github.com/DataDog/datadog-ruby_core_source/actions/runs/12354204200/job/34475175057#step:4:5

**Additional Notes:**

N/A

**How to test the change?**

Without this PR, locally running `bundle exec rake` fails for me
with the error above; with this change, I'm able to run `rake`
successfully.
@ivoanjo ivoanjo assigned AlexJF and unassigned AlexJF Dec 16, 2024
@ivoanjo
ivoanjo requested review from a team and AlexJF December 16, 2024 14:10
@ivoanjo
ivoanjo enabled auto-merge December 16, 2024 14:12
@ivoanjo
ivoanjo merged commit 2138124 into master Dec 16, 2024
@ivoanjo
ivoanjo deleted the ivoanjo/prof-11035-clean-up-gemfile branch December 16, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants