[PROF-11035] Fix breaking "publish gem" due to optional development group#12
Merged
Merged
Conversation
…roup **What does this PR do?** This PR removes the optional development group with the `pry` gem. It was added in #8, but it being optional breaks the "publish gem" github flow with: ``` Run bundle exec rake release bundler: failed to load command: rake (/opt/hostedtoolcache/Ruby/3.2.4/x64/bin/rake) /opt/hostedtoolcache/Ruby/3.2.4/x64/lib/ruby/3.2.0/bundler/rubygems_integration.rb:308:in `block in replace_bin_path': can't find executable rake for gem rake. rake is not currently included in the bundle, perhaps you meant to add it to your Gemfile? (Gem::Exception) ``` I was able to reproduce the same issue locally, it happens because the development group was marked optional. Since this has been a bit of a back and forth, for now let's just remove `pry` and we can add it back locally or whatnot if when needed. **Motivation:** This is blocking the 3.3.7 release, see https://github.com/DataDog/datadog-ruby_core_source/actions/runs/12354204200/job/34475175057#step:4:5 **Additional Notes:** N/A **How to test the change?** Without this PR, locally running `bundle exec rake` fails for me with the error above; with this change, I'm able to run `rake` successfully.
anmarchenko
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the optional development group with the
prygem. It was added in #8, but it being optional breaks the "publish gem" github flow with:I was able to reproduce the same issue locally, it happens because the development group was marked optional.
Since this has been a bit of a back and forth, for now let's just remove
pryand we can add it back locally or whatnot if when needed.Motivation:
This is blocking the 3.3.7 release, see
https://github.com/DataDog/datadog-ruby_core_source/actions/runs/12354204200/job/34475175057#step:4:5
Additional Notes:
N/A
How to test the change?
Without this PR, locally running
bundle exec rakefails for me with the error above; with this change, I'm able to runrakesuccessfully.