Skip to content

[Backport v1.29] Resolve several GKE Autopilot gaps with Helm (#3234)#3249

Merged
levan-m merged 1 commit into
v1.29from
backport-3234-to-v1.29
Jul 10, 2026
Merged

[Backport v1.29] Resolve several GKE Autopilot gaps with Helm (#3234)#3249
levan-m merged 1 commit into
v1.29from
backport-3234-to-v1.29

Conversation

@levan-m

@levan-m levan-m commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator
  • set DD_PROVIDER_KIND en and env.datadoghq.com/kind annotation in agent

  • Step 2: feature supressions, FIPS proxy

  • Add no-connect annotation to agent DS

  • add CCR to comprehensive golden test fixture

Enable clusterChecks.useClusterChecksRunners in the comprehensive DDA so the CCR Deployment appears in all comprehensive golden variants.

  • set DD_PROVIDER_KIND in CRC, DCA; DD_CLOUD_PROVIDER_METADATA in DCA

  • Drop GPU and SBOM supression to be handled by feature validation

  • Fix golden test

  • Revert "Drop GPU and SBOM supression to be handled by feature validation"

This reverts commit 3b0f2fd. GPU and SBOM suppressions are kept; F4 validation will handle user-facing errors for unsupported features.

  • Revert no-connect annotation (d5d9a35); restore GPU/SBOM drop

Drop the misleading cafeb8c (which accidentally reverted the GPU/SBOM suppression drop instead of the no-connect annotation commit).

Revert d5d9a35: the autopilot.gke.io/no-connect annotation belongs on the pod template, not the DaemonSet object metadata, and requires a narrower version range than an unconditional apply. Removing ApplyProviderObjectAnnotations and its two call sites from controller_reconcile_agent.go.

GPU and SBOM provider suppressions are restored as-is (they were correctly dropped in 3b0f2fd since Helm hard-fails on those features for Autopilot; partial suppression is misleading).

Golden files regenerated.


(cherry picked from commit 84a47fd)

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

* set DD_PROVIDER_KIND en and env.datadoghq.com/kind annotation in agent

* Step 2: feature supressions, FIPS proxy

* Add no-connect annotation to agent DS

* add CCR to comprehensive golden test fixture

Enable clusterChecks.useClusterChecksRunners in the comprehensive DDA so
the CCR Deployment appears in all comprehensive golden variants.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

* set DD_PROVIDER_KIND in CRC, DCA; DD_CLOUD_PROVIDER_METADATA in DCA

* Drop GPU and SBOM supression to be handled by feature validation

* Fix golden test

* Revert "Drop GPU and SBOM supression to be handled by feature validation"

This reverts commit 3b0f2fd. GPU and SBOM suppressions are kept;
F4 validation will handle user-facing errors for unsupported features.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

* Revert no-connect annotation (d5d9a35); restore GPU/SBOM drop

Drop the misleading cafeb8c (which accidentally reverted the
GPU/SBOM suppression drop instead of the no-connect annotation commit).

Revert d5d9a35: the autopilot.gke.io/no-connect annotation belongs
on the pod template, not the DaemonSet object metadata, and requires a
narrower version range than an unconditional apply. Removing
ApplyProviderObjectAnnotations and its two call sites from
controller_reconcile_agent.go.

GPU and SBOM provider suppressions are restored as-is (they were
correctly dropped in 3b0f2fd since Helm hard-fails on those features
for Autopilot; partial suppression is misleading).

Golden files regenerated.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

---------

Co-authored-by: Claude Sonnet 4.6 <[email protected]>
Co-authored-by: Timothée Bavelier <[email protected]>
(cherry picked from commit 84a47fd)
@levan-m levan-m added this to the v1.29.0 milestone Jul 10, 2026
@levan-m levan-m added the enhancement New feature or request label Jul 10, 2026
@levan-m
levan-m requested review from a team as code owners July 10, 2026 16:18
@levan-m levan-m added qa/skip-qa backport label added by backport action labels Jul 10, 2026
@levan-m levan-m changed the title Resolve several GKE Autopilot gaps with Helm (#3234) [Backport v1.29] Resolve several GKE Autopilot gaps with Helm (#3234) Jul 10, 2026
@datadog-datadog-prod-us1

Copy link
Copy Markdown

Code Coverage

Fix all issues with BitsAI

🛑 Gate Violations

🎯 1 Code Coverage issue detected

A Patch coverage percentage gate may be blocking this PR.

Patch coverage: 16.67% (threshold: 80.00%)

ℹ️ Info

🎯 Code Coverage (details)
Patch Coverage: 16.67%
Overall Coverage: 46.35% (-0.00%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9c79c01 | Docs | Datadog PR Page | Give us feedback!

@levan-m
levan-m merged commit 20caa17 into v1.29 Jul 10, 2026
44 of 52 checks passed
@levan-m
levan-m deleted the backport-3234-to-v1.29 branch July 10, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants