[Backport v1.29] Resolve several GKE Autopilot gaps with Helm (#3234)#3249
Merged
Conversation
* set DD_PROVIDER_KIND en and env.datadoghq.com/kind annotation in agent * Step 2: feature supressions, FIPS proxy * Add no-connect annotation to agent DS * add CCR to comprehensive golden test fixture Enable clusterChecks.useClusterChecksRunners in the comprehensive DDA so the CCR Deployment appears in all comprehensive golden variants. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * set DD_PROVIDER_KIND in CRC, DCA; DD_CLOUD_PROVIDER_METADATA in DCA * Drop GPU and SBOM supression to be handled by feature validation * Fix golden test * Revert "Drop GPU and SBOM supression to be handled by feature validation" This reverts commit 3b0f2fd. GPU and SBOM suppressions are kept; F4 validation will handle user-facing errors for unsupported features. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * Revert no-connect annotation (d5d9a35); restore GPU/SBOM drop Drop the misleading cafeb8c (which accidentally reverted the GPU/SBOM suppression drop instead of the no-connect annotation commit). Revert d5d9a35: the autopilot.gke.io/no-connect annotation belongs on the pod template, not the DaemonSet object metadata, and requires a narrower version range than an unconditional apply. Removing ApplyProviderObjectAnnotations and its two call sites from controller_reconcile_agent.go. GPU and SBOM provider suppressions are restored as-is (they were correctly dropped in 3b0f2fd since Helm hard-fails on those features for Autopilot; partial suppression is misleading). Golden files regenerated. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> --------- Co-authored-by: Claude Sonnet 4.6 <[email protected]> Co-authored-by: Timothée Bavelier <[email protected]> (cherry picked from commit 84a47fd)
🛑 Gate Violations
ℹ️ Info🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 9c79c01 | Docs | Datadog PR Page | Give us feedback! |
zhuminyi
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set DD_PROVIDER_KIND en and env.datadoghq.com/kind annotation in agent
Step 2: feature supressions, FIPS proxy
Add no-connect annotation to agent DS
add CCR to comprehensive golden test fixture
Enable clusterChecks.useClusterChecksRunners in the comprehensive DDA so the CCR Deployment appears in all comprehensive golden variants.
set DD_PROVIDER_KIND in CRC, DCA; DD_CLOUD_PROVIDER_METADATA in DCA
Drop GPU and SBOM supression to be handled by feature validation
Fix golden test
Revert "Drop GPU and SBOM supression to be handled by feature validation"
This reverts commit 3b0f2fd. GPU and SBOM suppressions are kept; F4 validation will handle user-facing errors for unsupported features.
Drop the misleading cafeb8c (which accidentally reverted the GPU/SBOM suppression drop instead of the no-connect annotation commit).
Revert d5d9a35: the autopilot.gke.io/no-connect annotation belongs on the pod template, not the DaemonSet object metadata, and requires a narrower version range than an unconditional apply. Removing ApplyProviderObjectAnnotations and its two call sites from controller_reconcile_agent.go.
GPU and SBOM provider suppressions are restored as-is (they were correctly dropped in 3b0f2fd since Helm hard-fails on those features for Autopilot; partial suppression is misleading).
Golden files regenerated.
(cherry picked from commit 84a47fd)
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel