Clean registry migration and force GCR on GKE Autopilot if unset#3240
Conversation
🛑 Gate Violations
ℹ️ Info🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 3672d18 | Docs | Datadog PR Page | Give us feedback! |
|
|
||
| // IsGCRRegistry reports whether registry points to a Datadog GCR registry, | ||
| // including the known regional GCR registries. | ||
| func IsGCRRegistry(registry string) bool { |
There was a problem hiding this comment.
us.gcr.io also exists and could be added here? Also, maybe we can make this more resilient by using regex if we expect the gcr.io in the name? This will make it so that no specific Operator version is pinned down to the registries that existed when the Operator was released.
There was a problem hiding this comment.
I initially went indeed with something that only looks for gcr.io string inside repositories, but felt like it was cleaner like this. We (Datadog) only use gcr.io/datadoghq, eu.gcr.io/datadoghq and asia one. If we add a new GCR registry, it will need to be present in operator code anyway, so this function can then be updated imho. What do you think ?
There was a problem hiding this comment.
Yeah I think this is fine! I'm split 50/50 either way on it
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.29 v1.29
# Navigate to the new working tree
cd .worktrees/backport-v1.29
# Create a new branch
git switch --create backport-3240-to-v1.29
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 eda77d82eeb31ca6cbecfe014347d873b1c43446
# Push it to GitHub
git push --set-upstream origin backport-3240-to-v1.29
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.29Then, create a pull request where the |
…) (#3254) * Default Agent images to Datadog registry * Force GCR registry for Autopilot * Trim registry defaulting test matrix
2 participants
What does this PR do?
registry.datadoghq.comand removes theDD_REGISTRY_OVERRIDE_*migration path.Motivation
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
registry.datadoghq.comby default when deploying onkindgcr.io/datadoghq.Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel