update bundle for 1.28.0#3237
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a65a9dabd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| containerImage: | ||
| description: ContainerImage identifies container image names |
There was a problem hiding this comment.
The bundle CRD is reverting the DatadogInstrumentation check selector to containerImage, but the current API type and generated base CRD define DatadogInstrumentationCheckConfig.ContainerName with JSON field containerName (api/datadoghq/v1alpha1/datadoginstrumentation_types.go:41-43 and config/crd/bases/v1/datadoghq.com_datadoginstrumentations.yaml:65-67). In OLM installs using this bundle, valid checks[].containerName values are pruned/rejected by the CRD, while containerImage is not read by the operator's typed API, so users cannot target checks to a container by name.
Useful? React with 👍 / 👎.
| logs: | ||
| description: Logs contains log collection configuration | ||
| payloads for this integration. | ||
| items: |
There was a problem hiding this comment.
The bundle schema nests log configs back under each check, but the current API and base CRD expose logs as spec.config.logs[] with a required containerName (api/datadoghq/v1alpha1/datadoginstrumentation_types.go:30-33 and :123-129). With this OLM CRD, valid top-level log configs are pruned/rejected, and nested checks[].logs never populate DatadogInstrumentationConfig.Logs, so DatadogInstrumentation log collection cannot be configured through the bundle.
Useful? React with 👍 / 👎.
|
🎯 Code Coverage (details) 🔗 Commit SHA: 7a65a9d | Docs | Datadog PR Page | Give us feedback! |
2 participants
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel