Skip to content

chore(instrumentationCrd): bump minimum version to 7.82#3223

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
mathew.estafanous/crd-bump-min-version
Jul 6, 2026
Merged

chore(instrumentationCrd): bump minimum version to 7.82#3223
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
mathew.estafanous/crd-bump-min-version

Conversation

@Mathew-Estafanous

@Mathew-Estafanous Mathew-Estafanous commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Bumps the minimum agent version required for Instrumentation CRD to 7.82.x.
  • Adds node agent version check for instrumentation CRD feature enablement.

Motivation

A breaking change has been made to the instrumentation CRD controller starting in 7.82.x, which means this unreleased feature now requires 7.82.x to properly function. The operator should disable the feature if the deployed agent & cluster agent are below 7.82

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: v7.82.x
  • Cluster Agent: v7.82.x

Describe your test plan

  • Added unit tests ✅

Manual QA.

  1. Deploy agent with version >= 7.82.0
apiVersion: datadoghq.com/v2alpha1
kind: DatadogAgent
metadata:
  name: datadog
  annotations:
    agent.datadoghq.com/instrumentation-crd-enabled: "true" # annotation enabling the feature
spec:
  global:
    logLevel: "info"
    clusterName: mathewe-inst-controller
    credentials:
      apiSecret:
        secretName: datadog-secret
        keyName: api-key
      appSecret:
        secretName: datadog-secret
        keyName: app-key
    kubelet:
      tlsVerify: false
  1. Confirm both cluster and core agent have DD_INSTRUMENTATION_CRD_CONTROLLER_ENABLED: "true" env var set.
  2. Drop agent image below 7.82
  3. Confirm both cluster and core agent do not have DD_INSTRUMENTATION_CRD_CONTROLLER_ENABLED set to true.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@Mathew-Estafanous Mathew-Estafanous self-assigned this Jul 6, 2026
@Mathew-Estafanous Mathew-Estafanous added this to the v1.29.0 milestone Jul 6, 2026
@Mathew-Estafanous Mathew-Estafanous added the enhancement New feature or request label Jul 6, 2026
@Mathew-Estafanous
Mathew-Estafanous marked this pull request as ready for review July 6, 2026 15:47
@Mathew-Estafanous
Mathew-Estafanous requested a review from a team July 6, 2026 15:47

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1e706bddbd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +72 to +73
version := common.GetAgentVersionFromImage(*nodeAgent.Image)
if !utils.IsAboveMinVersion(version, minVersion, nil) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fall back for partial node image overrides

When override.nodeAgent.image is present only to set fields like pullPolicy, pullSecrets, or jmxEnabled, GetAgentVersionFromImage returns an empty string; with the nil fallback here, IsAboveMinVersion treats that as supported. The pod image still inherits images.AgentLatestVersion through the image override path, which is 7.80.2 in this commit, so an annotated DDA with a supported Cluster Agent override but a partial Node Agent image override enables the instrumentation CRD env var on an unsupported Node Agent instead of taking the default-version branch. Please distinguish a missing version from an unparseable custom tag before accepting it.

Useful? React with 👍 / 👎.

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jul 6, 2026

Copy link
Copy Markdown

Code Coverage

Fix all issues with BitsAI

🛑 Gate Violations

🎯 1 Code Coverage issue detected

A Patch coverage percentage gate may be blocking this PR.

Patch coverage: 47.37% (threshold: 80.00%)

ℹ️ Info

🎯 Code Coverage (details)
Patch Coverage: 47.37%
Overall Coverage: 45.79%

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4c108cd | Docs | Datadog PR Page | Give us feedback!

@Mathew-Estafanous
Mathew-Estafanous force-pushed the mathew.estafanous/crd-bump-min-version branch from 1e706bd to a832284 Compare July 6, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants