chore(instrumentationCrd): bump minimum version to 7.82#3223
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e706bddbd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| version := common.GetAgentVersionFromImage(*nodeAgent.Image) | ||
| if !utils.IsAboveMinVersion(version, minVersion, nil) { |
There was a problem hiding this comment.
Fall back for partial node image overrides
When override.nodeAgent.image is present only to set fields like pullPolicy, pullSecrets, or jmxEnabled, GetAgentVersionFromImage returns an empty string; with the nil fallback here, IsAboveMinVersion treats that as supported. The pod image still inherits images.AgentLatestVersion through the image override path, which is 7.80.2 in this commit, so an annotated DDA with a supported Cluster Agent override but a partial Node Agent image override enables the instrumentation CRD env var on an unsupported Node Agent instead of taking the default-version branch. Please distinguish a missing version from an unparseable custom tag before accepting it.
Useful? React with 👍 / 👎.
🛑 Gate Violations
ℹ️ Info🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 4c108cd | Docs | Datadog PR Page | Give us feedback! |
1e706bd to
a832284
Compare
1072511
into
main
What does this PR do?
7.82.x.Motivation
A breaking change has been made to the instrumentation CRD controller starting in
7.82.x, which means this unreleased feature now requires7.82.xto properly function. The operator should disable the feature if the deployed agent & cluster agent are below 7.82Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Manual QA.
7.82.0DD_INSTRUMENTATION_CRD_CONTROLLER_ENABLED: "true"env var set.7.82DD_INSTRUMENTATION_CRD_CONTROLLER_ENABLEDset to true.Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel