Skip to content

Enable hostPID for the GPU feature#3220

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
guillermo.julian/gpu-enable-hostpid
Jul 3, 2026
Merged

Enable hostPID for the GPU feature#3220
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
guillermo.julian/gpu-enable-hostpid

Conversation

@gjulianm

@gjulianm gjulianm commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

The Node Agent pod now runs in the host PID namespace when the GPU feature is enabled.

Motivation

GPU monitoring watches host processes, which requires the host PID namespace. It is also a prerequisite for patchCgroupPermissions: the cgroup permissions patch resolves the host pid 1 cgroup and is a no-op without it. Unlike the Helm chart, the operator does not enable hostPID by default, so this was previously missing.

Additional Notes

Minimum Agent Versions

  • Agent: N/A
  • Cluster Agent: N/A

Describe your test plan

  1. Deploy DDA with gpuM enabled
  2. Verify hostPID is set for Agent pod

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@gjulianm gjulianm added qa/skip-qa bug Something isn't working labels Jul 3, 2026 — with Graphite App
@gjulianm
gjulianm marked this pull request as ready for review July 3, 2026 10:46
@gjulianm
gjulianm requested a review from a team July 3, 2026 10:46
@gjulianm
gjulianm requested a review from a team as a code owner July 3, 2026 10:46
@datadog-datadog-prod-us1

Copy link
Copy Markdown

Code Coverage

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 45.57% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8388dea | Docs | Datadog PR Page | Give us feedback!

@tbavelier tbavelier added this to the v1.29.0 milestone Jul 3, 2026

@mbertrone mbertrone left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — non-blocking question + nit inline.

Comment thread internal/controller/datadogagent/feature/gpu/feature.go
Comment thread internal/controller/datadogagent/feature/gpu/feature_test.go
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 8cf0aa8 into main Jul 3, 2026
67 of 69 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the guillermo.julian/gpu-enable-hostpid branch July 3, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants