Rename provider annotation key to agent.datadoghq.com/cluster-provider#3219
Conversation
Aligns the DDA/DDAI provider annotation with the agent.datadoghq.com namespace used by other provider-related keys, and disambiguates it from the per-daemonset agent.datadoghq.com/provider override label. Co-Authored-By: Claude Sonnet 5 <[email protected]>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e993226edd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const ( | ||
| // DDA/DDAI annotation key for provider used in reconciler to apply provider-specific configs | ||
| ProviderAnnotationKey = "datadoghq.com/provider" | ||
| ProviderAnnotationKey = "agent.datadoghq.com/cluster-provider" |
There was a problem hiding this comment.
When upgrading an existing DatadogAgent or DatadogAgentProfile annotated with datadoghq.com/provider (for example gke-cos to strip /usr/src mounts, or openshift-rhcos), this rename makes the reconciler ignore that user override because resolveClusterProvider and the DDAI reconciler only read ProviderAnnotationKey. The old annotation is still copied through as inert metadata, so clusters can silently lose provider-specific mutations until users manually rename the annotation; please keep accepting the old key during migration.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Not sure it's really a concern, we've not documented it yet, and mostly relying on auto detection from the status which should not change
This comment has been minimized.
This comment has been minimized.
2 participants
What does this PR do?
Aligns the DDA/DDAI provider annotation with the agent.datadoghq.com namespace used by other provider-related keys, and disambiguates it from the per-daemonset agent.datadoghq.com/provider override label.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel