Skip to content

Drop empty provider label from DDAI agent override#3217

Merged
tbavelier merged 1 commit into
mainfrom
levan-m/drop-ddai-empty-override
Jul 8, 2026
Merged

Drop empty provider label from DDAI agent override#3217
tbavelier merged 1 commit into
mainfrom
levan-m/drop-ddai-empty-override

Conversation

@levan-m

@levan-m levan-m commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

DDAI is created with an empty provider label override, which is confusing or redundant at least.

  override:
    nodeAgent:
      labels:
        agent.datadoghq.com/provider: ""

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Apply DDA with provider annotation

apiVersion: datadoghq.com/v2alpha1
kind: DatadogAgent
metadata:
  annotations:
    datadoghq.com/provider: aks
...
...

and observe DDAI is created without

  override:
    nodeAgent:
      labels:
        agent.datadoghq.com/provider: ""

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@levan-m levan-m added this to the v1.29.0 milestone Jul 2, 2026
@levan-m
levan-m requested a review from a team July 2, 2026 22:06
@levan-m levan-m added the bug Something isn't working label Jul 2, 2026
@datadog-datadog-us1-prod

This comment has been minimized.

@tbavelier
tbavelier merged commit 5760e61 into main Jul 8, 2026
45 checks passed
@tbavelier
tbavelier deleted the levan-m/drop-ddai-empty-override branch July 8, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working team/container-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants