Add shared dependencies#3183
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 168e9297b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
khewonc
force-pushed
the
khewonc/dap-deps
branch
from
June 23, 2026 20:11
168e929 to
81d283c
Compare
3 tasks
levan-m
reviewed
Jul 2, 2026
| } | ||
| // SSI is configured on the Cluster Agent, so profile SSI config needs a | ||
| // shared-component overlay in addition to the normal per-DDAI feature path. | ||
| err = feature.RegisterProfileSharedConfigOverlay(feature.APMIDType, applyAPMProfileSharedConfigOverlay) |
Collaborator
There was a problem hiding this comment.
I guess the asymmetry with otel, dsd, otlp feature is due to the fact that we don't allow feature overrides for those in DAP right? once we do we will also add overlays and validation before DDAI creation?
levan-m
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add shared dependencies. Dependencies that can be configured by both DDA and DDAIs and are 1 per cluster are "shared" dependencies since we can't create 1 per DDA/DDAI. These are things like local service for APM/DSD and eventually seccomp profile configmap
Motivation
https://datadoghq.atlassian.net/browse/CONTP-1762
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Create a DDA and DAP with hostports set to different values:
The DDA value
8126should be in the resulting service (kubectl get svc <local-agent-svc-name>). In the operator logs, you will see this error:local Agent Service port xxxx conflicts with existing portwhere xxxx is the conflicting portChecklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel