Skip to content

Add shared dependencies#3183

Merged
khewonc merged 3 commits into
mainfrom
khewonc/dap-deps
Jul 2, 2026
Merged

Add shared dependencies#3183
khewonc merged 3 commits into
mainfrom
khewonc/dap-deps

Conversation

@khewonc

@khewonc khewonc commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Add shared dependencies. Dependencies that can be configured by both DDA and DDAIs and are 1 per cluster are "shared" dependencies since we can't create 1 per DDA/DDAI. These are things like local service for APM/DSD and eventually seccomp profile configmap

Motivation

https://datadoghq.atlassian.net/browse/CONTP-1762

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Create a DDA and DAP with hostports set to different values:

# dda
    features:
      apm:
        enabled: true
        hostPortConfig:
          enabled: true
          hostPort: 8126
# dap
    features:
      apm:
        enabled: true
        hostPortConfig:
          enabled: true
          hostPort: 8127

The DDA value 8126 should be in the resulting service (kubectl get svc <local-agent-svc-name>). In the operator logs, you will see this error: local Agent Service port xxxx conflicts with existing port where xxxx is the conflicting port

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@khewonc khewonc added this to the v1.29.0 milestone Jun 22, 2026
@khewonc
khewonc requested a review from a team June 22, 2026 22:03
@khewonc
khewonc requested review from a team as code owners June 22, 2026 22:03
@khewonc khewonc added the enhancement New feature or request label Jun 22, 2026
@khewonc
khewonc requested review from mackjmr and removed request for a team June 22, 2026 22:03

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 168e9297b9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/controller/datadogagent/dependencies.go Outdated
@datadog-prod-us1-5

This comment has been minimized.

}
// SSI is configured on the Cluster Agent, so profile SSI config needs a
// shared-component overlay in addition to the normal per-DDAI feature path.
err = feature.RegisterProfileSharedConfigOverlay(feature.APMIDType, applyAPMProfileSharedConfigOverlay)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the asymmetry with otel, dsd, otlp feature is due to the fact that we don't allow feature overrides for those in DAP right? once we do we will also add overlays and validation before DDAI creation?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right

@khewonc
khewonc force-pushed the khewonc/dap-deps branch from 81d283c to 4840a0a Compare July 2, 2026 22:22
@khewonc
khewonc merged commit 9f2359f into main Jul 2, 2026
29 of 39 checks passed
@khewonc
khewonc deleted the khewonc/dap-deps branch July 2, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants