Do not use direct apireader client and instead make f.etcdSecretPresent as part of existing calls#3180
Conversation
…nt as part of existing calls
🛑 Gate Violations
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0286a7d906
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| f.etcdSecretPresent = true | ||
| return true | ||
| return f.etcdSecretPresent |
There was a problem hiding this comment.
When DatadogAgentProfile is enabled, non-default profile DDAIs skip manageFeatureDependencies (controller_reconcile_v2.go lines 68-83) but still run reconcileV2Agent (line 106), so this field is never set for those feature instances. On OpenShift with control plane monitoring and a profile-selected node pool, the default DDAI can create/retain etcd-metric-client, but profile DaemonSets will see false here and omit the etcd cert volume/mount, preventing the etcd check from authenticating on those nodes.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## levan-m/introspection-ddai-fix-podstartup #3180 +/- ##
============================================================================
Coverage ? 44.40%
============================================================================
Files ? 378
Lines ? 30912
Branches ? 0
============================================================================
Hits ? 13726
Misses ? 16290
Partials ? 896
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
6dba535
into
levan-m/introspection-ddai-fix-podstartup
* Avoid agent getting stuck in container creating * Do not use direct apireader client and instead make f.etcdSecretPresent as part of existing calls (#3180) --------- Co-authored-by: Timothée Bavelier <[email protected]>
* Extend introspection and support DDAI code path * handle edge cases when user unsets annotation * pr review fixes * skip adding default provider to ddai * remove logging * Copy OpenShift etcd metric secret (#3131) * copy OpenShift etcd metric secret * Add 5s timeout * Keep existing secret if source read fails * fix podstartup (#3179) * Avoid agent getting stuck in container creating * Do not use direct apireader client and instead make f.etcdSecretPresent as part of existing calls (#3180) --------- Co-authored-by: Timothée Bavelier <[email protected]> --------- Co-authored-by: Timothée Bavelier <[email protected]>
3 participants
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
Review of #3179
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel