[CASCL-1386] (7/11) Evict EKS managed node groups#3174
Merged
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 7f9f9f5 | Docs | Datadog PR Page | Give us feedback! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## lenaic/CASCL-1386-evict-06-ec2-instance-id-helper #3174 +/- ##
=====================================================================================
+ Coverage 44.05% 44.12% +0.07%
=====================================================================================
Files 389 389
Lines 31093 31132 +39
=====================================================================================
+ Hits 13698 13737 +39
Misses 16501 16501
Partials 894 894
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-07-eks-mng
branch
from
June 19, 2026 14:21
c0c8b6a to
9250b71
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-06-ec2-instance-id-helper
branch
from
June 19, 2026 14:21
dd81350 to
0f545f7
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-07-eks-mng
branch
from
June 22, 2026 13:24
9250b71 to
f9c10d1
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-06-ec2-instance-id-helper
branch
from
June 22, 2026 13:25
0f545f7 to
3b7cda6
Compare
5 tasks
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-07-eks-mng
branch
2 times, most recently
from
June 25, 2026 08:18
8e43ad1 to
3718447
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-06-ec2-instance-id-helper
branch
2 times, most recently
from
June 26, 2026 12:16
91c9a7b to
0f3bbd1
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-07-eks-mng
branch
from
June 26, 2026 12:16
3718447 to
6c79f69
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-06-ec2-instance-id-helper
branch
from
June 26, 2026 14:45
0f3bbd1 to
e69973f
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-07-eks-mng
branch
2 times, most recently
from
June 29, 2026 15:41
f91f53d to
7322549
Compare
Base automatically changed from
lenaic/CASCL-1386-evict-06-ec2-instance-id-helper
to
main
June 29, 2026 15:44
L3n41c
marked this pull request as ready for review
June 29, 2026 15:58
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d6b7023b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
L3n41c
changed the base branch from
main
to
lenaic/CASCL-1386-evict-06.5-cordon-drain
July 1, 2026 13:46
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-07-eks-mng
branch
2 times, most recently
from
July 1, 2026 22:58
409d632 to
5884694
Compare
Introduce the reusable node-cordon and pod-eviction/drain primitives that the per-manager evictors (EKS managed node groups, ASG, Karpenter, standalone) build on: - cordonNodes/cordonNode: idempotent, conflict-retrying cordon that treats an already-gone node as a silent skip and returns the cordoned Node objects. - drainNode: evicts every evictable pod (skipping mirror, DaemonSet, completed and terminating pods), then waits for the node to empty. - evictPodWithRetry: PDB-aware eviction that retries on 429 and treats 404 as success. - listPodsOnNode, waitForNodeEmpty and the pod-classification predicates (podOccupiesNode/shouldSkipEviction/isMirrorPod/isDaemonSetPod/isCompleted). These primitives have no production caller yet; the first (evictEKSManagedNode- Group) lands in the next PR in the stack. A temporary blank-identifier reference keeps golangci-lint's `unused` quiet until then (the linter runs with tests = false, so the unit tests do not count as use) and is removed by that PR.
Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-07-eks-mng
branch
from
July 2, 2026 09:43
5884694 to
eec5e58
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-06.5-cordon-drain
branch
from
July 2, 2026 09:43
47f7ed9 to
39bbf26
Compare
AlexanderYastrebov
approved these changes
Jul 2, 2026
Base automatically changed from
lenaic/CASCL-1386-evict-06.5-cordon-drain
to
main
July 3, 2026 09:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements EKS managed node group eviction (scale-to-zero then wait; EKS drains pods server-side, so it needs no client-side drain primitives).
Motivation
PR #3026 is too large to review as a single change. This is part 7 of 11 of a stack that splits it into small, individually-reviewable pieces that each build and pass tests on their own. See #3026 for the full feature context and end-to-end QA.
Additional Notes
Stacked PR — the base branch is
lenaic/CASCL-1386-evict-06-ec2-instance-id-helper, notmain, so the diff shows only this step's change. Implements an evictor the skeleton (part 1) left stubbed. The code is taken verbatim from #3026 (rebased ontomain); there are no logic changes versus #3026.Minimum Agent Versions
N/A —
kubectl-datadogplugin only.Describe your test plan
go test ./cmd/kubectl-datadog/autoscaling/cluster/...passes at this commit. Full end-to-end QA is tracked on #3026.Checklist
qa/skip-qalabel applied (not independently shippable; QA tracked on [CASCL-1386] Add evict-legacy-nodes subcommand to drain non-Datadog node groups #3026)