[CASCL-1386] (6/11) Extract shared EC2 instance-ID helper to common/aws#3173
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## lenaic/CASCL-1386-evict-05-cluster-autoscaler #3173 +/- ##
=================================================================================
+ Coverage 44.04% 44.05% +0.01%
=================================================================================
Files 388 389 +1
Lines 31087 31093 +6
=================================================================================
+ Hits 13692 13698 +6
Misses 16501 16501
Partials 894 894
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
🛑 Gate Violations
ℹ️ Info🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: f33a8bb | Docs | Datadog PR Page | Give us feedback! |
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-05-cluster-autoscaler
branch
from
June 19, 2026 14:21
dfa2be6 to
1303499
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-06-ec2-instance-id-helper
branch
from
June 19, 2026 14:21
dd81350 to
0f545f7
Compare
Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-05-cluster-autoscaler
branch
from
June 22, 2026 13:25
1303499 to
4a328cf
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-06-ec2-instance-id-helper
branch
from
June 22, 2026 13:25
0f545f7 to
3b7cda6
Compare
5 tasks
Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-05-cluster-autoscaler
branch
from
June 23, 2026 08:49
4a328cf to
05481ca
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-06-ec2-instance-id-helper
branch
from
June 23, 2026 08:49
3b7cda6 to
06f31c4
Compare
Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-05-cluster-autoscaler
branch
from
June 25, 2026 08:18
05481ca to
ce64343
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-06-ec2-instance-id-helper
branch
2 times, most recently
from
June 26, 2026 12:16
91c9a7b to
0f3bbd1
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-05-cluster-autoscaler
branch
from
June 26, 2026 12:16
ce64343 to
1ed7ac0
Compare
Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
…-nodes Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands. Co-Authored-By: Claude Opus 4.8 <[email protected]>
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-06-ec2-instance-id-helper
branch
from
June 26, 2026 14:45
0f3bbd1 to
e69973f
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-05-cluster-autoscaler
branch
from
June 26, 2026 14:45
1ed7ac0 to
563df65
Compare
Base automatically changed from
lenaic/CASCL-1386-evict-05-cluster-autoscaler
to
main
June 29, 2026 12:15
L3n41c
marked this pull request as ready for review
June 29, 2026 12:40
hmahmood
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extracts EC2 provider-ID parsing into a shared
commonaws.ExtractEC2InstanceIDhelper and reuses it fromclassifyandfromnodes, removing the duplicated regex.Motivation
PR #3026 is too large to review as a single change. This is part 6 of 11 of a stack that splits it into small, individually-reviewable pieces that each build and pass tests on their own. See #3026 for the full feature context and end-to-end QA.
Additional Notes
Stacked PR — the base branch is
lenaic/CASCL-1386-evict-05-cluster-autoscaler, notmain, so the diff shows only this step's change. Self-contained refactor used by later eviction parts. The code is taken verbatim from #3026 (rebased ontomain); there are no logic changes versus #3026.Minimum Agent Versions
N/A —
kubectl-datadogplugin only.Describe your test plan
go test ./cmd/kubectl-datadog/autoscaling/cluster/...passes at this commit. Full end-to-end QA is tracked on #3026.Checklist
qa/skip-qalabel applied (not independently shippable; QA tracked on [CASCL-1386] Add evict-legacy-nodes subcommand to drain non-Datadog node groups #3026)