[CASCL-1386] (5/11) Scale down the cluster-autoscaler before eviction#3164
Merged
Conversation
🛑 Gate Violations
ℹ️ Info🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 5d85b81 | Docs | Datadog PR Page | Give us feedback! |
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-04-preflight
branch
from
June 18, 2026 15:41
1107a29 to
49deb5c
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-05-cluster-autoscaler
branch
from
June 18, 2026 15:41
6423e9e to
dfa2be6
Compare
L3n41c
changed the title
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (74.07%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## lenaic/CASCL-1386-evict-04-preflight #3164 +/- ##
========================================================================
+ Coverage 44.01% 44.04% +0.03%
========================================================================
Files 388 388
Lines 31061 31087 +26
========================================================================
+ Hits 13671 13692 +21
- Misses 16499 16501 +2
- Partials 891 894 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-04-preflight
branch
from
June 19, 2026 14:21
49deb5c to
dd7f679
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-05-cluster-autoscaler
branch
from
June 19, 2026 14:21
dfa2be6 to
1303499
Compare
Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-04-preflight
branch
from
June 22, 2026 13:24
dd7f679 to
a8fa15e
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-05-cluster-autoscaler
branch
from
June 22, 2026 13:25
1303499 to
4a328cf
Compare
5 tasks
Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-04-preflight
branch
from
June 23, 2026 08:49
a8fa15e to
b03651d
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-05-cluster-autoscaler
branch
from
June 23, 2026 08:49
4a328cf to
05481ca
Compare
Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-05-cluster-autoscaler
branch
from
June 25, 2026 08:18
05481ca to
ce64343
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-04-preflight
branch
from
June 25, 2026 08:18
b03651d to
374d307
Compare
L3n41c
marked this pull request as ready for review
June 25, 2026 08:35
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce64343e28
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
AlexanderYastrebov
approved these changes
Jun 25, 2026
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-05-cluster-autoscaler
branch
from
June 26, 2026 12:16
ce64343 to
1ed7ac0
Compare
Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
…-nodes Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-05-cluster-autoscaler
branch
from
June 26, 2026 14:45
1ed7ac0 to
563df65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements
scaleDownClusterAutoscaler: scales the cluster-autoscaler Deployment to 0 replicas so it cannot provision new legacy nodes mid-drain.Motivation
PR #3026 is too large to review as a single change. This is part 5 of 11 of a stack that splits it into small, individually-reviewable pieces that each build and pass tests on their own. See #3026 for the full feature context and end-to-end QA.
Additional Notes
Stacked PR — the base branch is
lenaic/CASCL-1386-evict-04-preflight, notmain, so the diff shows only this step's change. Implements logic the skeleton (part 1) left stubbed. The code is taken verbatim from #3026 (rebased ontomain); there are no logic changes versus #3026.Minimum Agent Versions
N/A —
kubectl-datadogplugin only.Describe your test plan
go test ./cmd/kubectl-datadog/autoscaling/cluster/...passes at this commit. Full end-to-end QA is tracked on #3026.Checklist
qa/skip-qalabel applied (not independently shippable; QA tracked on [CASCL-1386] Add evict-legacy-nodes subcommand to drain non-Datadog node groups #3026)