[CASCL-1386] (4/11) Add evict-legacy-nodes preflight warnings#3163
Merged
Conversation
🛑 Gate Violations
ℹ️ Info🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 7cf1215 | Docs | Datadog PR Page | Give us feedback! |
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-03-prompt
branch
from
June 18, 2026 15:41
66deaee to
99db839
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-04-preflight
branch
from
June 18, 2026 15:41
1107a29 to
49deb5c
Compare
L3n41c
changed the title
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-04-preflight
branch
from
June 19, 2026 14:21
49deb5c to
dd7f679
Compare
Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-04-preflight
branch
from
June 22, 2026 13:24
dd7f679 to
a8fa15e
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-03-prompt
branch
from
June 22, 2026 13:25
3471309 to
8316f55
Compare
5 tasks
Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-04-preflight
branch
from
June 23, 2026 08:49
a8fa15e to
b03651d
Compare
Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-04-preflight
branch
from
June 25, 2026 08:18
b03651d to
374d307
Compare
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-03-prompt
branch
from
June 25, 2026 08:18
0213012 to
802e3c1
Compare
L3n41c
marked this pull request as ready for review
June 25, 2026 08:31
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 374d307f83
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
AlexanderYastrebov
approved these changes
Jun 25, 2026
Part of a stack splitting #3026 (too large to review in one piece) into small pieces that each build and pass tests on their own. The command is fully functional only once the whole stack lands.
…ight' into lenaic/CASCL-1386-evict-04-preflight
L3n41c
force-pushed
the
lenaic/CASCL-1386-evict-04-preflight
branch
from
June 26, 2026 15:18
2ced16b to
7cf1215
Compare
Member
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7cf1215e53
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements the non-blocking preflight warnings (e.g. user Karpenter NodePool weight conflicts) shown before eviction.
Motivation
PR #3026 is too large to review as a single change. This is part 4 of 11 of a stack that splits it into small, individually-reviewable pieces that each build and pass tests on their own. See #3026 for the full feature context and end-to-end QA.
Additional Notes
Stacked PR — the base branch is
lenaic/CASCL-1386-evict-03-prompt, notmain, so the diff shows only this step's change. Implements logic the skeleton (part 1) left stubbed. The code is taken verbatim from #3026 (rebased ontomain); there are no logic changes versus #3026.Minimum Agent Versions
N/A —
kubectl-datadogplugin only.Describe your test plan
go test ./cmd/kubectl-datadog/autoscaling/cluster/...passes at this commit. Full end-to-end QA is tracked on #3026.Checklist
qa/skip-qalabel applied (not independently shippable; QA tracked on [CASCL-1386] Add evict-legacy-nodes subcommand to drain non-Datadog node groups #3026)