aks provider support by levan-m · Pull Request #3150 · DataDog/datadog-operator

levan-m · 2026-06-16T16:05:02Z

What does this PR do?

CONTP-1567

Adds support for aks provider supported in helm.

Easiest to review commit-by-commit:
228abde refactor provider capabilities to drop NodeAgent for naming.
711d01b support aks provider to customize DCA config.

Motivation

Related issue #2746.

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

Agent: vX.Y.Z
Cluster Agent: vX.Y.Z

Describe your test plan

user operator renderer or kind cluster to generate DCA Deployment manifest

Apply

apiVersion: datadoghq.com/v2alpha1
kind: DatadogAgent
metadata:
  name: datadog
  namespace: datadog
  annotations:
    datadoghq.com/provider: aks
spec:
  global:
    credentials:
      apiSecret:
        secretName: datadog-secret
        keyName: api-key

verify DCA container has env var

        - name: DD_ADMISSION_CONTROLLER_ADD_AKS_SELECTORS
          value: "true"

Remove provider or disable DCA (spec.features.admissionController.enabled: false)
DD_ADMISSION_CONTROLLER_ADD_AKS_SELECTORS shouldn't be added

Checklist

PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
PR has a milestone or the qa/skip-qa label
All commits are signed (see: signing commits)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c1c5b9282f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-16T16:10:03Z

        - /manager
        args:
-        - --enable-leader-election
+        - --enable-leader-election=false


Restore leader election in manager manifests

config/default and config/test-v1 both include ../manager, so this base Deployment is what users render/install. With this flag forced to false, any rolling update (the Deployment defaults allow a surge pod even with replicas: 1) or manual scale-out starts multiple active controller managers; the flag help in cmd/main.go says leader election is what ensures only one active manager. Please keep leader election enabled in the shipped manifest.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-06-16T16:10:03Z

 		}
 	}

+	provider := instance.GetAnnotations()[kubernetes.ProviderAnnotationKey]


Wire AKS support to the public Helm/CRD input

Here the AKS capability is driven solely by the datadoghq.com/provider annotation on the generated DDAI. The Helm compatibility path that users reported (providers.aks.enabled) still maps to "" in cmd/yaml-mapper/mapper/mapping_datadog_helm_to_datadogagent_crd.yaml, and no CRD field was added, so a DatadogAgent/Helm conversion using global.providers.aks.enabled: true still produces no DD_ADMISSION_CONTROLLER_ADD_AKS_SELECTORS. Please wire that public input to this provider value.

Useful? React with 👍 / 👎.

datadog-datadog-prod-us1-2 · 2026-06-16T16:22:07Z

✨ Fix all issues with BitsAI

🛑 Gate Violations

🎯 1 Code Coverage issue detected

A Patch coverage percentage gate may be blocking this PR.

• Patch coverage: 0.00% (threshold: 80.00%)

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 0.00%
• Overall Coverage: 44.02% (-0.03%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 711d01b | Docs | Datadog PR Page | Give us feedback!}

codecov-commenter · 2026-06-16T16:24:19Z

Codecov Report

❌ Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.76%. Comparing base (68e2ee9) to head (711d01b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...atadogagent/feature/admissioncontroller/feature.go	0.00%	14 Missing ⚠️
...ler/datadogagentinternal/component_clusteragent.go	0.00%	6 Missing ⚠️
...datadogagentinternal/controller_reconcile_agent.go	0.00%	4 Missing ⚠️
...controller/datadogagent/feature/oomkill/feature.go	0.00%	2 Missing ⚠️
...ler/datadogagent/feature/tcpqueuelength/feature.go	0.00%	2 Missing ⚠️
...oller/datadogagentinternal/component_reconciler.go	0.00%	2 Missing ⚠️
...er/datadogagentinternal/controller_reconcile_v2.go	0.00%	2 Missing ⚠️
...datadogagent/providercaps/provider_capabilities.go	0.00%	1 Missing ⚠️
...adogagentinternal/component_clusterchecksrunner.go	0.00%	1 Missing ⚠️
...datadogagentinternal/component_otelagentgateway.go	0.00%	1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3150      +/-   ##
==========================================
- Coverage   43.79%   43.76%   -0.03%     
==========================================
  Files         375      375              
  Lines       30575    30594      +19     
==========================================
  Hits        13390    13390              
- Misses      16276    16295      +19     
  Partials      909      909

Flag	Coverage Δ
unittests	`43.76% <0.00%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
internal/controller/datadogagent/feature/types.go	`22.10% <ø> (ø)`
pkg/kubernetes/provider.go	`86.36% <ø> (ø)`
...datadogagent/providercaps/provider_capabilities.go	`0.00% <0.00%> (ø)`
...adogagentinternal/component_clusterchecksrunner.go	`0.00% <0.00%> (ø)`
...datadogagentinternal/component_otelagentgateway.go	`0.00% <0.00%> (ø)`
...controller/datadogagent/feature/oomkill/feature.go	`73.21% <0.00%> (ø)`
...ler/datadogagent/feature/tcpqueuelength/feature.go	`73.43% <0.00%> (ø)`
...oller/datadogagentinternal/component_reconciler.go	`0.00% <0.00%> (ø)`
...er/datadogagentinternal/controller_reconcile_v2.go	`0.00% <0.00%> (ø)`
...datadogagentinternal/controller_reconcile_agent.go	`4.03% <0.00%> (ø)`
... and 2 more

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68e2ee9...711d01b. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gabedos

lgtm

nit: could we add a unit test that covers the expected changes for each provider? this would help us ensure that code changes don't introduce any regressions in the final manifest for the different providers (aks, gke, eks, etc)

refactor, drop NodeAgent prefix from ProviderCapabilities sumbols

228abde

levan-m added this to the v1.29.0 milestone Jun 16, 2026

levan-m requested a review from a team June 16, 2026 16:05

levan-m added the enhancement New feature or request label Jun 16, 2026

levan-m requested review from a team as code owners June 16, 2026 16:05

github-actions Bot added team/agent-security team/container-platform team/ebpf-platform labels Jun 16, 2026

support AKS provider

711d01b

levan-m force-pushed the levan-m/aks-provider-support branch from c1c5b92 to 711d01b Compare June 16, 2026 16:08

chatgpt-codex-connector Bot reviewed Jun 16, 2026

View reviewed changes

levan-m changed the title ~~Levan m/aks provider support~~ aks provider support Jun 16, 2026

gabedos approved these changes Jun 16, 2026

View reviewed changes

levan-m merged commit 3748b72 into main Jun 16, 2026
37 of 38 checks passed

levan-m deleted the levan-m/aks-provider-support branch June 16, 2026 20:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

aks provider support#3150

aks provider support#3150
levan-m merged 2 commits into
mainfrom
levan-m/aks-provider-support

levan-m commented Jun 16, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jun 16, 2026

Uh oh!

chatgpt-codex-connector Bot Jun 16, 2026

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Jun 16, 2026

🎯 1 Code Coverage issue detected

Uh oh!

codecov-commenter commented Jun 16, 2026

Uh oh!

gabedos left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

levan-m commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

Minimum Agent Versions

Describe your test plan

Checklist

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Jun 16, 2026

🛑 Gate Violations

🎯 1 Code Coverage issue detected

ℹ️ Info

Uh oh!

codecov-commenter commented Jun 16, 2026

Codecov Report

Uh oh!

gabedos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

levan-m commented Jun 16, 2026 •

edited

Loading