[Backport v1.28] discovery: remove networkStats option#3123
Conversation
(cherry picked from commit d06e2cb)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 432a50a85d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| Default: true when omitted and the node Agent image is >= 7.78.0. Otherwise false. | ||
| If the image version cannot be determined, it is treated as latest. | ||
| type: boolean | ||
| networkStats: | ||
| description: 'DEPRECATED: NetworkStats is no longer configurable and will be ignored. Scheduled for removal in v1.28.' | ||
| properties: | ||
| enabled: | ||
| description: 'DEPRECATED: this field is ignored.' | ||
| type: boolean | ||
| type: object | ||
| type: object |
There was a problem hiding this comment.
This removes networkStats from the generated base CRD, but the release artifacts still ship the old schema: I checked rg -n "networkStats" bundle/manifests marketplaces and found it under bundle/manifests/datadoghq.com_datadogagents.yaml and the Google marketplace/addon manifests. In environments that install the operator through OLM bundles or marketplace packages, the CRDs will still advertise and accept this removed field, so the v1.28 removal is not actually reflected in the installable artifacts.
Useful? React with 👍 / 👎.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1.28 #3123 +/- ##
=======================================
Coverage 43.44% 43.44%
=======================================
Files 350 350
Lines 29994 29994
=======================================
Hits 13031 13031
Misses 16091 16091
Partials 872 872
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
3 participants
Backport d06e2cb from #3117.
What does this PR do?
Follow-up to #2822, this PR finally removes the discovery network stats option from the operator.
Motivation
DSCVR-416
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
No.
Describe your test plan
N/A
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel