support nested SGC config options#3120
Conversation
s-alad
added
bug
|
🎯 Code Coverage (details) 🔗 Commit SHA: f4b3541 | Docs | Datadog PR Page | Give us feedback! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3120 +/- ##
=======================================
Coverage 43.49% 43.49%
=======================================
Files 352 352
Lines 30025 30025
=======================================
Hits 13058 13058
Misses 16095 16095
Partials 872 872
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b23a5b7490
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4 participants
What does this PR do?
Changes spec.global.secretBackend.config from
map[string]stringtomap[string]apiextensionsv1.JSON, so it can hold the nested config that built-in secret backends requireMotivation
https://datadoghq.atlassian.net/browse/AGENT-16274
Additional Notes
map[string]interface{}as a solution doesn't work,make generate manifestscan't build a schema or correct deepcopy for bareinterface{}Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Unit Tests:
TestSecretBackendConfigNestedDecodeTestNodeAgentComponenGlobalSettingsManual:
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel