discovery: remove networkStats option#3117
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3117 +/- ##
=======================================
Coverage 43.48% 43.48%
=======================================
Files 352 352
Lines 30020 30020
=======================================
Hits 13053 13053
Misses 16095 16095
Partials 872 872
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0db3138f8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
(cherry picked from commit d06e2cb) Co-authored-by: Guillaume Pagnoux <[email protected]>
…et guard The embedded mapping table had drifted from the authoritative helm-charts copy (charts/datadog/files/...). Reconcile the two into one byte-identical table: port the 238 mappings the operator copy already had into helm-charts, add the newer helm keys, and on the 2 conflicting keys keep the helm-charts target (the operator copy was stale). Coverage goes from 132 to 366 mapped keys. Also reset the stale datadog.discovery.networkStats.enabled mapping, whose CRD field was removed in #3117. Add TestMappingTargetsExistInCRD, which validates every mapping target against the DatadogAgent v2alpha1 CRD schema and fails the build on a dead path (the kind of rot the networkStats mapping was). Environment: Datadog workspace Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
3 participants
What does this PR do?
Follow-up to #2822, this PR finally removes the discovery network stats option from the operator.
Motivation
DSCVR-416
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
No.
Describe your test plan
N/A
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel