Skip to content

[Backport v1.28] [Host Profiler] Remove seccomp configmap and use profile baked into image#3107

Merged
khewonc merged 3 commits into
v1.28from
backport-3061-to-v1.28
Jun 9, 2026
Merged

[Backport v1.28] [Host Profiler] Remove seccomp configmap and use profile baked into image#3107
khewonc merged 3 commits into
v1.28from
backport-3061-to-v1.28

Conversation

@dd-octo-sts

@dd-octo-sts dd-octo-sts Bot commented Jun 8, 2026

Copy link
Copy Markdown

Backport df55a51 from #3061.


What does this PR do?

Leverages the seccomp profile now bundled in the Host Profiler's image.
DataDog/datadog-agent#51545

Motivation

Before this, the seccomp profile was living in 3 different places:

  • datadog-operator
  • datadog's helm-charts
  • Standalone documentation

Bundling the seccomp directly in the image and using it as an initContainer enables us the version the seccomp profile with profiler versions and maintain only one copy.

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Used this branch alongside the datadog-agent PR's standalone image to test.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

…mage (#3061)

remove seccomp configmap and use profile baked into image

add seccomp profile dynamic naming based on image hash

add support for separate image/tag attributes and add testing

rework resolveHostProfilerImage to account for dda image override annotations

add IPC_LOCK cap

Co-authored-by: theo.demagalhaes <[email protected]>
(cherry picked from commit df55a51)
@dd-octo-sts dd-octo-sts Bot added the enhancement New feature or request label Jun 8, 2026
@dd-octo-sts
dd-octo-sts Bot requested a review from a team as a code owner June 8, 2026 17:17
@dd-octo-sts dd-octo-sts Bot added qa/skip-qa mergequeue-status: done backport label added by backport action bot label added by backport bot team/profiling-full-host labels Jun 8, 2026
@dd-octo-sts
dd-octo-sts Bot requested a review from a team as a code owner June 8, 2026 17:17
@codecov-commenter

codecov-commenter commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 43.44%. Comparing base (104bcf9) to head (739dbd3).

Files with missing lines Patch % Lines
...oller/datadogagent/feature/hostprofiler/feature.go 96.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            v1.28    #3107      +/-   ##
==========================================
- Coverage   43.64%   43.44%   -0.20%     
==========================================
  Files         350      350              
  Lines       30097    29994     -103     
==========================================
- Hits        13135    13031     -104     
- Misses      16090    16091       +1     
  Partials      872      872              
Flag Coverage Δ
unittests 43.44% <96.77%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...oller/datadogagent/feature/hostprofiler/seccomp.go 100.00% <100.00%> (ø)
...oller/datadogagent/feature/hostprofiler/feature.go 82.07% <96.00%> (+0.07%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 104bcf9...739dbd3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Jun 8, 2026

Copy link
Copy Markdown

Pipelines  Code Coverage

Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

DataDog/datadog-operator | e2e: [1.19]   View in Datadog   GitLab

DataDog/datadog-operator | e2e: [1.22]   View in Datadog   GitLab

ℹ️ Info

🎯 Code Coverage (details)
Patch Coverage: 96.55%
Overall Coverage: 43.74% (-0.22%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 739dbd3 | Docs | Datadog PR Page | Give us feedback!

@khewonc
khewonc merged commit 4a8f342 into v1.28 Jun 9, 2026
34 of 36 checks passed
@khewonc
khewonc deleted the backport-3061-to-v1.28 branch June 9, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport label added by backport action bot label added by backport bot enhancement New feature or request mergequeue-status: done qa/skip-qa team/profiling-full-host

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants