[Backport v1.28] enable CNM direct send by default#3103
Conversation
enable CNM direct send by default fix default test proper fix add test for USM defaults if enabled use annotation instead of CRD re-generate fix default fix default test fix process-agent apparmor default to false for unknown versions Co-authored-by: bryce.kahle <[email protected]> (cherry picked from commit 5c6a923)
|
🎯 Code Coverage (details) 🔗 Commit SHA: 3ed142c | Docs | Datadog PR Page | Give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ed142c465
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1.28 #3103 +/- ##
==========================================
+ Coverage 43.62% 43.64% +0.01%
==========================================
Files 350 350
Lines 30089 30097 +8
==========================================
+ Hits 13127 13135 +8
Misses 16090 16090
Partials 872 872
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Backport 5c6a923 from #3045.
What does this PR do?
Enables CNM/USM direct send if agent version is >= 7.81.0
Motivation
Enabling direct send at the operator level first.
Additional Notes
Minimum Agent Versions
Describe your test plan
Add
agent.datadoghq.com/cnm-direct-send-enabled=trueannotationDD_NETWORK_CONFIG_DIRECT_SEND=falsedirect sender startedlog should NOT be present insystem-probelogs.process-agentcontainer should be presentDD_NETWORK_CONFIG_DIRECT_SEND=truedirect sender startedlog should be present insystem-probelogs.process-agentcontainer should NOT be presentSet
agent.datadoghq.com/cnm-direct-send-enabled=falseannotationDD_NETWORK_CONFIG_DIRECT_SEND=falsedirect sender startedlog should NOT be present insystem-probelogs.process-agentcontainer should be presentChecklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel