Skip to content

[CONTP-1702] Support CSI mode in GKE Autopilot#3094

Merged
tbavelier merged 4 commits into
mainfrom
tbavelier/CONTP-1702-autopilot-csi-driver
Jun 12, 2026
Merged

[CONTP-1702] Support CSI mode in GKE Autopilot#3094
tbavelier merged 4 commits into
mainfrom
tbavelier/CONTP-1702-autopilot-csi-driver

Conversation

@tbavelier

@tbavelier tbavelier commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

  • Supports CSI in GKE Autopilot by creating the allowlist synchronizer when enabled on a DDA with GKE Autopilot annotation experimental.agent.datadoghq.com/autopilot: "true"

Motivation

What inspired you to submit this pull request?

Additional Notes

Cherry-picked changes from #3093 , only change for now is f2aa75a which includes allowlistsynchronizer

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

  • On a GKE Autopilot cluster, enable csidrivers (if not already enabled), have global.csi.enabled=true in your DatadogAgent (with GKE Autopilot annotation experimental.agent.datadoghq.com/autopilot: "true"): and verify the allowlistsynchronizer is created, the ddcsi custom resource is reconciled properly, so the daemonset should be created

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@tbavelier tbavelier added this to the v1.28.0 milestone Jun 5, 2026
@tbavelier tbavelier added the enhancement New feature or request label Jun 5, 2026
@datadog-official

datadog-official Bot commented Jun 5, 2026 •
edited by datadog-datadog-prod-us1-2 Bot
Loading

Copy link
Copy Markdown

Code Coverage  Pipelines

✨ Fix all issues with BitsAI

🛑 Gate Violations

🎯 1 Code Coverage issue detected

A Patch coverage percentage gate may be blocking this PR.

• Patch coverage: 68.75% (threshold: 80.00%)

⚠️ Warnings

🚦 1 Pipeline job failed

DataDog/datadog-operator | e2e_autoscaling   View in Datadog   GitLab

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 68.75%
• Overall Coverage: 43.70% (+0.03%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 996be6e | Docs | Datadog PR Page | Give us feedback!

@codecov-commenter

codecov-commenter commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.42%. Comparing base (f36836a) to head (996be6e).

Files with missing lines Patch % Lines
.../controller/datadogagent/experimental/autopilot.go 0.00% 7 Missing ⚠️
pkg/allowlistsynchronizer/allowlistsynchronizer.go 78.78% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3094      +/-   ##
==========================================
+ Coverage   43.39%   43.42%   +0.02%     
==========================================
  Files         354      354              
  Lines       30102    30136      +34     
==========================================
+ Hits        13064    13086      +22     
- Misses      16165    16177      +12     
  Partials      873      873
Flag Coverage Δ
unittests 43.42% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/controller/datadogagent/ddcsi.go 82.52% <100.00%> (+0.34%) ⬆️
.../controller/datadogagent/experimental/autopilot.go 57.66% <0.00%> (-3.11%) ⬇️
pkg/allowlistsynchronizer/allowlistsynchronizer.go 73.56% <78.78%> (+2.59%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f36836a...996be6e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tbavelier
tbavelier marked this pull request as ready for review June 12, 2026 12:10
@tbavelier
tbavelier requested a review from a team June 12, 2026 12:10
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jun 12, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 996be6e832

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pkg/allowlistsynchronizer/allowlistsynchronizer.go
@tbavelier
tbavelier merged commit 3b09cf8 into main Jun 12, 2026
38 of 40 checks passed
@tbavelier
tbavelier deleted the tbavelier/CONTP-1702-autopilot-csi-driver branch June 12, 2026 15:02
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Jun 12, 2026
Merged
3 tasks
gh-worker-dd-mergequeue-cf854d Bot pushed a commit that referenced this pull request Jun 12, 2026
@dd-octo-sts @tbavelier
[CONTP-1702] Support CSI mode in GKE Autopilot (#3094) (#3133)
4d241e3 
[CONTP-1702] Support CSI mode in GKE Autopilot (#3094)

* Add GKE Autopilot allowlist for Datadog CSI driver

* Align with Helm Daemonset: volumes, deprecated registry, APM annotation

* Add spec.apm.enabled field to condition the CSIDriver annotation and daemonset env var

(cherry picked from commit 3b09cf8)

Co-authored-by: tbavelier <[email protected]>
Co-authored-by: timothee.bavelier <[email protected]>
@iamluc iamluc mentioned this pull request Jun 25, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@khewonc khewonc khewonc approved these changes

Assignees

No one assigned

Labels

backport/v1.28 enhancement New feature or request team/container-platform

Projects

None yet

Milestone

v1.28.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tbavelier @codecov-commenter @khewonc