Skip to content

fix: change issuer and subject also in prod#3088

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
antonio.mejia/fix-policy-prod
Jun 4, 2026
Merged

fix: change issuer and subject also in prod#3088
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
antonio.mejia/fix-policy-prod

Conversation

@dd-anmejia

@dd-anmejia dd-anmejia commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Changes issuer from Ticino to Vault since our service has isp: True (uses the ISP sidecar to authenticate — that issues Vault OIDC tokens)
  • Changes the subject to a UUID for Vault issuer accornding to the spec

Tests

  • Only able to test after merge

@dd-anmejia
dd-anmejia requested a review from a team June 4, 2026 15:53
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jun 4, 2026 •
edited by datadog-prod-us1-5 Bot
Loading

Copy link
Copy Markdown

Pipelines  Code Coverage

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

pull request linter | Check Milestone   View in Datadog   GitHub Actions

See error Missing milestone or `qa/skip-qa` label.

pull request linter | build   View in Datadog   GitHub Actions

See error Job failed due to missing required labels. Valid labels: ['bug', 'enhancement', 'refactoring', 'documentation', 'tooling', 'dependencies'].

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 43.96% (+0.00%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1db6636 | Docs | Datadog PR Page | Give us feedback!

@dd-anmejia

dd-anmejia commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-04 15:58:08 UTC ℹ️ Start processing command /merge

2026-06-04 15:58:13 UTC ❌ MergeQueue

You are not allowed to use the merge queue towards main. User is not part of the authorized users or teams.
The authorized teams (including their child teams) are: agent-all, injection-platform, container-apps-and-remediation, container-integrations, containers-tee, Documentation, profiling-full-host, action-platform.

@codecov-commenter

codecov-commenter commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.64%. Comparing base (e62a2b2) to head (1db6636).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3088   +/-   ##
=======================================
  Coverage   43.64%   43.64%           
=======================================
  Files         350      350           
  Lines       30075    30075           
=======================================
  Hits        13125    13125           
  Misses      16079    16079           
  Partials      871      871
Flag Coverage Δ
unittests 43.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e62a2b2...1db6636. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 6e4ddc3 into main Jun 4, 2026
62 of 64 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the antonio.mejia/fix-policy-prod branch June 4, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mathew-Estafanous Mathew-Estafanous Mathew-Estafanous approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done qa/skip-qa team/container-platform tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dd-anmejia @codecov-commenter @Mathew-Estafanous