Skip to content

fix: change issuer and subject according to dd-octo-sts spec#3084

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
antonio.mejia/fix-policy
Jun 4, 2026
Merged

fix: change issuer and subject according to dd-octo-sts spec#3084
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
antonio.mejia/fix-policy

Conversation

@dd-anmejia

@dd-anmejia dd-anmejia commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Changes issuer from Ticino to Vault since our service has isp: True (uses the ISP sidecar to authenticate — that issues Vault OIDC tokens)
  • Changes the subject to a UUID for Vault issuer accornding to the spec

Tests

  • Only able to test after merge

@dd-anmejia
dd-anmejia requested a review from a team June 4, 2026 03:17
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Jun 4, 2026

Copy link
Copy Markdown

Pipelines  Code Coverage

Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

pull request linter | Check Milestone   View in Datadog   GitHub Actions

See error Missing milestone or `qa/skip-qa` label.

pull request linter | build   View in Datadog   GitHub Actions

See error No valid labels found in the pull request. Required labels: ['bug', 'enhancement', 'refactoring', 'documentation', 'tooling', 'dependencies']

ℹ️ Info

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 43.94% (+0.00%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 663c637 | Docs | Datadog PR Page | Give us feedback!

@codecov-commenter

codecov-commenter commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.62%. Comparing base (19c5d3f) to head (663c637).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3084   +/-   ##
=======================================
  Coverage   43.62%   43.62%           
=======================================
  Files         349      349           
  Lines       30057    30057           
=======================================
  Hits        13112    13112           
  Misses      16075    16075           
  Partials      870      870           
Flag Coverage Δ
unittests 43.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19c5d3f...663c637. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit a1cbe91 into main Jun 4, 2026
62 of 64 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the antonio.mejia/fix-policy branch June 4, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants