update bundle for 1.27#3081
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 324acdac50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - dashboard | ||
| - downtime | ||
| - monitor | ||
| - notebook |
There was a problem hiding this comment.
The bundle CRD is what OLM installs, but this enum still omits slo even though the generated source CRD and API type include it (config/crd/bases/v1/datadoghq.com_datadoggenericresources.yaml and api/datadoghq/v1alpha1/datadoggenericresource_types.go). With this bundle, any DatadogGenericResource using spec.type: slo is rejected by Kubernetes schema validation before the controller can reconcile it, so the 1.27 bundle cannot use the SLO support documented for this resource.
Useful? React with 👍 / 👎.
| spot: | ||
| description: |- | ||
| Spot contains the configuration for the spot instance scheduling sub-feature. | ||
| Requires cluster autoscaling to be enabled. | ||
| (Requires Cluster Agent 7.79.0+) | ||
| properties: | ||
| enabled: | ||
| description: |- | ||
| Enabled enables the cluster spot scheduling product. | ||
| (Requires Cluster Agent 7.79.0+) | ||
| Default: false | ||
| type: boolean | ||
| type: object |
There was a problem hiding this comment.
This regenerated bundle schema still diverges from the generated CRDs: config/crd/bases/v1/datadoghq.com_datadogagents.yaml defines .spec.global.autoscaling.workload.inPlaceVerticalScaling.enabled, but the bundled DatadogAgent schema stops workload at enabled (and the same omission exists in the bundled AgentInternal/Profile schemas). OLM installs will therefore reject DatadogAgent resources that use the in-place vertical scaling option even though the operator API supports it.
Useful? React with 👍 / 👎.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3081 +/- ##
=======================================
Coverage 43.62% 43.62%
=======================================
Files 349 349
Lines 30057 30057
=======================================
Hits 13112 13112
Misses 16075 16075
Partials 870 870
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
3 participants
What does this PR do?
update bundle for 1.27
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel