Skip to content

switch to annotation#3080

Merged
Mathew-Estafanous merged 2 commits into
mathew.estafanous/instrumentation-crd-featurefrom
levan-m/instrumentationcrd-annotation
Jun 8, 2026
Merged

switch to annotation#3080
Mathew-Estafanous merged 2 commits into
mathew.estafanous/instrumentation-crd-featurefrom
levan-m/instrumentationcrd-annotation

Conversation

@levan-m

@levan-m levan-m commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Jun 3, 2026

Copy link
Copy Markdown

Pipelines  Code Coverage

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

pull request linter | build   View in Datadog   GitHub Actions

See error No valid labels found in the pull request. Required labels: ['bug', 'enhancement', 'refactoring', 'documentation', 'tooling', 'dependencies'].

ℹ️ Info

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 43.75%

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1eee449 | Docs | Datadog PR Page | Give us feedback!

@codecov-commenter

codecov-commenter commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (mathew.estafanous/instrumentation-crd-feature@d5080d6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...datadogagent/feature/instrumentationcrd/feature.go 42.85% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                               Coverage Diff                                @@
##             mathew.estafanous/instrumentation-crd-feature    #3080   +/-   ##
================================================================================
  Coverage                                                 ?   43.42%           
================================================================================
  Files                                                    ?      345           
  Lines                                                    ?    29824           
  Branches                                                 ?        0           
================================================================================
  Hits                                                     ?    12952           
  Misses                                                   ?    16036           
  Partials                                                 ?      836           
Flag Coverage Δ
unittests 43.42% <42.85%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nal/controller/datadogagent/feature/utils/utils.go 0.00% <ø> (ø)
pkg/testutils/builder.go 0.00% <ø> (ø)
pkg/testutils/ddai_builder.go 0.00% <ø> (ø)
...datadogagent/feature/instrumentationcrd/feature.go 60.60% <42.85%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5080d6...1eee449. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mathew-Estafanous
Mathew-Estafanous merged commit f7eff03 into mathew.estafanous/instrumentation-crd-feature Jun 8, 2026
34 of 35 checks passed
@Mathew-Estafanous
Mathew-Estafanous deleted the levan-m/instrumentationcrd-annotation branch June 8, 2026 15:18
gh-worker-dd-mergequeue-cf854d Bot pushed a commit that referenced this pull request Jun 10, 2026
…3002)

feat: add instrumentation controller crd feature

fix: remove default rbac test

chore: add instrumentation env var to single container

chore: change rbac name

Merge branch 'main' into mathew.estafanous/instrumentation-crd-feature

switch to annotation (#3080)

* switch to annotation

* fix linter

instrumentation crd feature on by default

minimum required version is 7.81

enable feature with annotation

switch to disable by default

Co-authored-by: levan-m <[email protected]>
Co-authored-by: mathew.estafanous <[email protected]>
Mathew-Estafanous added a commit that referenced this pull request Jun 11, 2026
…3002) (#3125)

feat: add instrumentation controller crd feature

fix: remove default rbac test

chore: add instrumentation env var to single container

chore: change rbac name

Merge branch 'main' into mathew.estafanous/instrumentation-crd-feature

switch to annotation (#3080)

* switch to annotation

* fix linter

instrumentation crd feature on by default

minimum required version is 7.81

enable feature with annotation

switch to disable by default



(cherry picked from commit 25a5943)

Co-authored-by: Mathew Estafanous <[email protected]>
Co-authored-by: levan-m <[email protected]>
Co-authored-by: mathew.estafanous <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants