fix(rbac): remove stale gateways entry from generated RBAC role#3075
Merged
Conversation
networking.istio.io/gateways was manually added to the orchestrator explorer RBAC block in role.yaml but has no corresponding kubebuilder marker. The permission is already granted by the AppSec marker (get;list;watch) which subsumes the orchestrator list;watch. Running make generate removes this stale duplicate. Confidence: high Scope-risk: narrow
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3075 +/- ##
=======================================
Coverage 43.10% 43.10%
=======================================
Files 341 341
Lines 29510 29510
=======================================
Hits 12721 12721
Misses 15965 15965
Partials 824 824
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
tbavelier
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes a stale
networking.istio.io/gatewaysentry from the orchestrator explorer RBAC block inconfig/rbac/role.yaml. This entry was manually added and has no corresponding+kubebuilder:rbac:marker — runningmake generateremoves it.The permission is already granted by the AppSec marker (
get;list;watch) which subsumes the orchestratorlist;watch, so this is a no-op from a runtime perspective.Motivation
Flagged by @tbavelier after merging #3053. The generated
role.yamlshould match whatmake generateproduces.Minimum Agent Versions
Describe your test plan
make generate && git diff --statproduces zero diff after this change.Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel