E2E improvements: remove gotoolchain hack, share go cache, stream test output#3074
Conversation
🛑 Gate Violations
ℹ️ Info🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 6d04376 | Docs | Datadog PR Page | Give us feedback! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3074 +/- ##
==========================================
+ Coverage 42.90% 43.42% +0.52%
==========================================
Files 341 342 +1
Lines 29403 29751 +348
==========================================
+ Hits 12614 12920 +306
- Misses 15965 15991 +26
- Partials 824 840 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: edfdc85b25
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ing image jobs + safety measure for dockerignore
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
3 participants
What does this PR do?
Improves the operator e2e CI pipeline by:
GOTOOLCHAINworkaroundgo_e2e_depsgo testoutput live in GitLab logsMotivation
Reduce duplicated Go dependency work across the Kubernetes-version e2e matrix and make long e2e runs easier to debug while they are running.
Additional Notes
The e2e Go cache is scoped to e2e jobs only, and
.go/.cacheare ignored from Docker build contexts.Minimum Agent Versions
Describe your test plan
116706367go_e2e_depscreates the e2e Go cache and matrix jobs restore itgo test ./hack/e2e-test-output -covergolangci-lint run ./hack/e2e-test-outputChecklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel