Exposes the ApiServerCache option in the datadog operator#3072
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 884dd8f | Docs | Datadog PR Page | Give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd44553d05
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3072 +/- ##
==========================================
+ Coverage 43.00% 44.06% +1.05%
==========================================
Files 340 350 +10
Lines 29330 30875 +1545
==========================================
+ Hits 12614 13604 +990
- Misses 15892 16374 +482
- Partials 824 897 +73
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 30 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Hi @sehgal23 👋
To avoid the DatadogAgent CRD becoming bloated, we need to be sure that a specific field is needed before adding it. Given that this setting might very well become a default, I'm not sure that it make sense to support it through the RFC assuming it can be also changed through environment variables or mounted KSM configuration for specific cases?
Thanks!
What does this PR do?
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
I spun up a local Kubernetes cluster using Colima and Minikube.
Built the operator image locally and loaded it into the cluster.
Updated the CRD to pick up the new useApiServerCache field.
Created the required secrets and applied a DatadogAgent resource with the agent.datadoghq.com/ksm-use-apiserver-cache annotation set to "true":
Verified that the operator generated the KSM Core check ConfigMap with the expected configuration:
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel