[CONTP-1585] Add SLO support to DatadogGenericResource#3070
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f150bd3ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3070 +/- ##
========================================
Coverage 43.00% 43.00%
========================================
Files 339 340 +1
Lines 29228 29330 +102
========================================
+ Hits 12570 12614 +44
- Misses 15836 15892 +56
- Partials 822 824 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
🛑 Gate Violations
ℹ️ Info🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: e42da66 | Docs | Datadog PR Page | Give us feedback! |
What does this PR do?
Adds Service Level Objective (SLO) as a supported
DatadogGenericResourcetype.This includes:
Motivation
https://datadoghq.atlassian.net/browse/CONTP-1585
Users can already manage SLOs through the dedicated
DatadogSLOCRD, butDatadogGenericResourceshould also support SLOs so users can manage the API object directly from JSON and benefit from DDGR's generic reconciliation flow.Additional Notes
SLO status refresh uses the SLO search endpoint with the SLO name from
spec.jsonSpec, then filters results by the Datadog SLO ID stored in.status.idbefore surfacingoverall_status[].stateinto.status.state.Minimum Agent Versions
No minimum Agent or Cluster Agent version is required.
Describe your test plan
DatadogGenericResourceenabled.examples/datadoggenericresource/slo-sample.yaml.k edit ddgr ddgr-slo-sampleand change the warning threshold.k get ddgr.Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel