Fix E2e tests on main#3064
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3064 +/- ##
=======================================
Coverage 43.00% 43.00%
=======================================
Files 339 339
Lines 29226 29226
=======================================
Hits 12568 12568
Misses 15836 15836
Partials 822 822
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
khewonc
marked this pull request as ready for review
June 1, 2026 17:56
khewonc
approved these changes
Jun 1, 2026
3 tasks
tbavelier
added a commit
that referenced
this pull request
Jun 2, 2026
* Use ECR registry instead of default registry.datadoghq.com * Disable log level when running status command to ensure no polluted output * Fix lint-e2e by using require.NoError --------- (cherry picked from commit 6ef503a) Co-authored-by: Timothée Bavelier <[email protected]> Co-authored-by: khewonc <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
agent status ... -jwithDD_LOG_LEVEL=offin k8s e2e checks so status output is clean JSON.agent status -joutput directly, failing when the command does not return valid JSON.Motivation
The e2e assertions were compensating for log lines mixed into
agent status -joutput by extracting the first JSON-looking object. Disabling Agent logging for status commands makes the command output deterministic and lets the tests validate the actual JSON contract.Additional Notes
No production code changes.
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
make lint-e2eChecklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel