[Host Profiler] Remove seccomp configmap and use profile baked into image#3061
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 1f4ff19 | Docs | Datadog PR Page | Give us feedback! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3061 +/- ##
==========================================
+ Coverage 43.64% 43.92% +0.28%
==========================================
Files 350 352 +2
Lines 30075 30374 +299
==========================================
+ Hits 13125 13342 +217
- Misses 16079 16151 +72
- Partials 871 881 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
theomagellan
changed the title
3c0461f to
16a44bf
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16a44bffce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16a44bffce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d909a5dcc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3d909a5 to
ec33f68
Compare
ec33f68 to
f896b9a
Compare
0d9819f to
78e1ff2
Compare
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
…mage (#3061) (#3107) remove seccomp configmap and use profile baked into image add seccomp profile dynamic naming based on image hash add support for separate image/tag attributes and add testing rework resolveHostProfilerImage to account for dda image override annotations add IPC_LOCK cap (cherry picked from commit df55a51) Co-authored-by: Théo de Magalhaes <[email protected]> Co-authored-by: theo.demagalhaes <[email protected]> Co-authored-by: khewonc <[email protected]>
5 participants
What does this PR do?
Leverages the seccomp profile now bundled in the Host Profiler's image.
DataDog/datadog-agent#51545
Motivation
Before this, the seccomp profile was living in 3 different places:
datadog-operatorhelm-chartsBundling the seccomp directly in the image and using it as an
initContainerenables us the version the seccomp profile with profiler versions and maintain only one copy.Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Used this branch alongside the datadog-agent PR's standalone image to test.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel