[CASCL-1292] Point the no-private-subnet error at all the install options#3056
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3056 +/- ##
=======================================
Coverage 43.03% 43.03%
=======================================
Files 339 339
Lines 29215 29215
=======================================
Hits 12573 12573
Misses 15820 15820
Partials 822 822
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
🎯 Code Coverage (details) 🔗 Commit SHA: 67afd89 | Docs | Datadog PR Page | Give us feedback! |
L3n41c
force-pushed
the
lenaic/CASCL-1292-guided-no-private-subnet-error
branch
from
May 29, 2026 15:33
c65ffa6 to
38f53bf
Compare
L3n41c
changed the title
…ions `autoscaling cluster install` defaults to fargate mode, which requires the cluster VPC to have a private subnet (an AWS Fargate constraint). When auto-detection found none, the error only mentioned `--fargate-subnets`, leaving users unaware they could simply run on existing nodes. Expand the message to name all three ways forward: add a private subnet, pass `--fargate-subnets` to specify them explicitly, or use `--install-mode=existing-nodes` to deploy on existing nodes instead of Fargate. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
L3n41c
force-pushed
the
lenaic/CASCL-1292-guided-no-private-subnet-error
branch
from
May 29, 2026 15:38
38f53bf to
67afd89
Compare
L3n41c
marked this pull request as ready for review
June 9, 2026 08:53
AlexanderYastrebov
approved these changes
Jun 9, 2026
| }, | ||
| expectError: true, | ||
| errorContains: "no private subnet found", | ||
| expectError: true, |
Contributor
There was a problem hiding this comment.
nit: expectError could be replaced with len(errorContains) > 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Expands the error message shown by
kubectl datadog autoscaling cluster installwhen its defaultfargatemode auto-detects no private subnet in the cluster VPC. The message now names all three ways forward instead of only one:--fargate-subnetsto specify them explicitly, or--install-mode=existing-nodesto deploy on existing nodes instead of Fargate.Motivation
During QA of the Fargate mode (CASCL-1292), a tester hit the private-subnet requirement on a VPC with only public subnets. Fargate is the default mode and the requirement is a hard AWS constraint (
AWS::EKS::FargateProfileonly accepts private subnets). The old message mentioned only--fargate-subnets, so the tester had to discover on their own that--install-mode=existing-nodesinstalls with no subnet requirement at all.Additional Notes
Deliberately minimal: a single error-message change in
GetClusterPrivateSubnetsplus a test update. No behavior change for successful installs.Minimum Agent Versions
No minimum Agent/Cluster Agent version required.
Describe your test plan
TestGetClusterPrivateSubnetsnow asserts the no-subnet error mentions the private-subnet requirement,--fargate-subnets, and--install-mode=existing-nodes.go test ./cmd/kubectl-datadog/autoscaling/...,make lint(0 issues),go vet,gofmtall pass.Checklist
enhancementqa/skip-qalabel