Skip to content

Expose workload autoscaling in-place vertical scaling#3055

Merged
triviajon merged 3 commits into
mainfrom
triviajon/ipvpa
Jun 1, 2026
Merged

Expose workload autoscaling in-place vertical scaling#3055
triviajon merged 3 commits into
mainfrom
triviajon/ipvpa

Conversation

@triviajon

@triviajon triviajon commented May 28, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds features.autoscaling.workload.inPlaceVerticalScaling.enabled to the DatadogAgent CR. When workload autoscaling and this sub-feature are both enabled, the operator sets DD_AUTOSCALING_WORKLOAD_IN_PLACE_VERTICAL_SCALING_ENABLED=true on the cluster agent.

Motivation

Ease of enablement for customers

Additional Notes

The RBAC required for in-place resize (pods/resize patch, pods/eviction create) is already granted whenever workload autoscaling is enabled

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Cluster Agent: v7.78.0

Describe your test plan

Added unit tests

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented May 28, 2026

Copy link
Copy Markdown

Code Coverage

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 43.38% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 240ec91 | Docs | Datadog PR Page | Give us feedback!

@codecov-commenter

codecov-commenter commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.04%. Comparing base (6b4b5f7) to head (240ec91).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3055      +/-   ##
==========================================
+ Coverage   43.03%   43.04%   +0.01%     
==========================================
  Files         339      339              
  Lines       29215    29222       +7     
==========================================
+ Hits        12573    12580       +7     
  Misses      15820    15820              
  Partials      822      822              
Flag Coverage Δ
unittests 43.04% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...roller/datadogagent/feature/autoscaling/feature.go 86.66% <100.00%> (+1.12%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b4b5f7...240ec91. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@triviajon
triviajon marked this pull request as ready for review May 28, 2026 19:50
@triviajon
triviajon requested a review from a team May 28, 2026 19:50
@triviajon
triviajon requested review from a team as code owners May 28, 2026 19:50
Comment thread internal/controller/datadogagent/feature/autoscaling/feature.go Outdated

@bitomaxsp bitomaxsp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid concern about name truncation

@triviajon
triviajon merged commit 079486f into main Jun 1, 2026
38 checks passed
@triviajon
triviajon deleted the triviajon/ipvpa branch June 1, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants