Skip to content

Align OTel collector config mount with Helm#3031

Merged
tbavelier merged 1 commit into
mainfrom
tbavelier/align-otel-agent-config-helm
May 20, 2026
Merged

Align OTel collector config mount with Helm#3031
tbavelier merged 1 commit into
mainfrom
tbavelier/align-otel-agent-config-helm

Conversation

@tbavelier

@tbavelier tbavelier commented May 20, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Aligns the operator-managed OTel Collector config mount with the Datadog Helm chart defaults.

This updates the node-agent OTel collector feature to:

  • mount the OTel config volume at /etc/otel-agent
  • pass --config=/etc/otel-agent/otel-config.yaml or --config=/etc/otel-agent/<item.path>
  • use the Helm-style volume name otelconfig
  • use the Helm-style generated ConfigMap suffix -otel-config

User-provided features.otelCollector.conf.configMap.name values are still honored as-is.

Motivation

The Helm chart mounts otel-config.yaml under /etc/otel-agent, while the operator previously mounted the standalone OTel config under /etc/datadog-agent. Matching Helm keeps the generated Kubernetes resources consistent across installation methods and avoids unnecessary differences in the otel-agent config path (also matching the required allowlist for GKE Autopilot)

Additional Notes

The OTel Agent Gateway config path is not changed in this PR; this only updates the DaemonSet/node-agent OTel collector config handled by features.otelCollector.

Minimum Agent Versions

No new minimum versions introduced by this change.

  • Agent: existing OTel Agent minimum applies
  • Cluster Agent: N/A

Describe your test plan

go test ./internal/controller/datadogagent/feature/otelcollector

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented May 20, 2026

Copy link
Copy Markdown

Pipelines  Code Coverage

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

pull request linter | Check Milestone   View in Datadog   GitHub Actions

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. Missing milestone or `qa/skip-qa` label during CI workflow validation.

ℹ️ Info

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 42.57% (+0.02%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2536856 | Docs | Datadog PR Page | Give us feedback!

@codecov-commenter

codecov-commenter commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.23%. Comparing base (f636740) to head (2536856).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3031      +/-   ##
==========================================
+ Coverage   42.20%   42.23%   +0.02%     
==========================================
  Files         337      337              
  Lines       28953    28957       +4     
==========================================
+ Hits        12221    12230       +9     
+ Misses      15926    15922       -4     
+ Partials      806      805       -1     
Flag Coverage Δ
unittests 42.23% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ller/datadogagent/feature/otelcollector/feature.go 79.73% <100.00%> (+2.60%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f636740...2536856. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tbavelier tbavelier added this to the v1.28.0 milestone May 20, 2026
@tbavelier
tbavelier marked this pull request as ready for review May 20, 2026 11:05
@tbavelier
tbavelier requested a review from a team May 20, 2026 11:05
@tbavelier
tbavelier requested a review from a team as a code owner May 20, 2026 11:05
@tbavelier
tbavelier requested a review from truthbk May 20, 2026 11:05
@tbavelier
tbavelier merged commit 65b9d19 into main May 20, 2026
49 of 51 checks passed
@tbavelier
tbavelier deleted the tbavelier/align-otel-agent-config-helm branch May 20, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants