You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The host-profiler seccomp setup init container now uses the image from the already-created host-profiler container instead of calling images.GetLatestAgentImage() directly.
Why
The host-profiler container image has already gone through the normal node-agent image resolution flow by the time ManageNodeAgent runs. That includes global registry and FIPS handling from global.ApplyGlobalSettingsNodeAgent / updateContainerImages.
Using images.GetLatestAgentImage() for the init container bypassed that resolved image and could make the pod reference a different Agent image than the host-profiler container. In practice, that can force nodes to pull the large Agent image more than once when registry/FIPS/global image settings rewrite the main container image but not this feature-added init container.
Reusing the resolved host-profiler image keeps the init container aligned with the main container and avoids extra image pulls for equivalent Agent content.
Validation
go test ./internal/controller/datadogagent/feature/hostprofiler ./internal/controller/datadogagent/component/agent ./internal/controller/datadogagent/feature/test ./internal/controller/datadogagentinternal
❌ Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.95%. Comparing base (b03042c) to head (55e981b).
🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration.
Missing milestone or `qa/skip-qa` label during CI workflow execution.
pull request linter | build
🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration.
Missing required labels for the pull request. Valid labels are: ['bug', 'enhancement', 'refactoring', 'documentation', 'tooling', 'dependencies'].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The host-profiler seccomp setup init container now uses the image from the already-created host-profiler container instead of calling
images.GetLatestAgentImage()directly.Why
The host-profiler container image has already gone through the normal node-agent image resolution flow by the time
ManageNodeAgentruns. That includes global registry and FIPS handling fromglobal.ApplyGlobalSettingsNodeAgent/updateContainerImages.Using
images.GetLatestAgentImage()for the init container bypassed that resolved image and could make the pod reference a different Agent image than the host-profiler container. In practice, that can force nodes to pull the large Agent image more than once when registry/FIPS/global image settings rewrite the main container image but not this feature-added init container.Reusing the resolved host-profiler image keeps the init container aligned with the main container and avoids extra image pulls for equivalent Agent content.
Validation
go test ./internal/controller/datadogagent/feature/hostprofiler ./internal/controller/datadogagent/component/agent ./internal/controller/datadogagent/feature/test ./internal/controller/datadogagentinternal